Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

bpo-36346: Make unicodeobject.h C89 compatible#20934

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
methane merged 1 commit intopython:masterfrommethane:fix-buildbot
Jun 17, 2020

Conversation

@methane
Copy link
Member

@methanemethane commentedJun 17, 2020•
edited by miss-islington
Loading

@methanemethane added type-bugAn unexpected behavior, bug, or error skip news labelsJun 17, 2020
@methanemethane requested a review fromvstinnerJune 17, 2020 12:31
@methanemethane added 🔨 test-with-buildbotsTest PR w/ buildbots; report in status section and removed CLA signed labelsJun 17, 2020
@bedevere-bot
Copy link

🤖 New build scheduled with the buildbot fleet by@methane for commit8b54cb7 🤖

If you want to schedule another build, you need to add the ":hammer: test-with-buildbots" label again.

@bedevere-botbedevere-bot removed the 🔨 test-with-buildbotsTest PR w/ buildbots; report in status section labelJun 17, 2020
Copy link
Member

@vstinnervstinner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

LGTM. But I suggest to change the commit title to "Make unicodeobject.h C89 compatible".

Py_UNICODE_FILL(Py_UNICODE *target, Py_UNICODE value, Py_ssize_t length) {
for (Py_ssize_t i =0; i < length; i++) {
Py_ssize_t i;
for (i =0; i < length; i++) {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

This change makes me sad :-( But well, as I wrote in the issue, I think that it's a good practice to try to keep C89 support for the public C API.

@methanemethane changed the titlebpo-36346: Fix buildbotsbpo-36346: Make unicodeobject.h C89 compatibleJun 17, 2020
@methanemethane merged commit8e34e92 intopython:masterJun 17, 2020
@methanemethane deleted the fix-buildbot branchJune 17, 2020 14:43
methane added a commit to methane/cpython that referenced this pull requestJun 17, 2020
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

@vstinnervstinnervstinner approved these changes

Assignees

No one assigned

Labels

skip newstype-bugAn unexpected behavior, bug, or error

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@methane@bedevere-bot@vstinner@the-knights-who-say-ni
[8]ページ先頭
©2009-2025 Movatter.jp