Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

bpo-30533:Add function inspect.getmembers_static that does not call properties or dynamic properties.#20911

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
DinoV merged 5 commits intopython:mainfromhongweipeng:add_getmembers_static
Nov 30, 2021

Conversation

hongweipeng
Copy link
Contributor

@hongweipenghongweipeng commentedJun 16, 2020
edited by bedevere-bot
Loading

@kernc
Copy link
Contributor

Also refs:https://bugs.python.org/issue38337
Closes:#16521

Copy link
Contributor

@itamaroitamaro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

I noticedbpo-30533 has this patch attached.

I was able to apply this patch cleanly on latest main branch, and built and ran thetest_inspect test.

Left a few comments around docstrings, but the functionality lgtm - would be great if a core dev could take a look :-)

kernc reacted with thumbs up emoji
Comment on lines 445 to 446
"""Return all members of an object as (name, value) pairs sorted by name.
Optionally, only return members that satisfy a given predicate."""
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

if this function is converted to an internal implementation detail with non-optionalpredicate andgetter args, need to either update the docstring to match the change, or drop the docstring altogether

DinoV reacted with thumbs up emoji
hongweipengand others added3 commitsNovember 10, 2021 20:00
Co-authored-by: Itamar Ostricher <itamarost@gmail.com>
Co-authored-by: Itamar Ostricher <itamarost@gmail.com>
Copy link
Contributor

@DinoVDinoV left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

LGTM,!

@DinoVDinoV merged commitaf8c8ca intopython:mainNov 30, 2021
@bedevere-bot
Copy link

@DinoV: Please replace# withGH- in the commit message next time. Thanks!

shihai1991 added a commit to shihai1991/cpython that referenced this pull requestDec 1, 2021
* main: (21 commits)  bpo-45876:  Have stdev() also use decimal specific square root. (pythonGH-29869)  bpo-45876:  Correctly rounded stdev() and pstdev() for the Decimal case (pythonGH-29828)  bpo-45711: Change exc_info related APIs to derive type and traceback from the exception instance (pythonGH-29780)  bpo-30533:Add function inspect.getmembers_static that does not call properties or dynamic properties. (python#20911)  bpo-45476: Disallow using asdl_seq_GET() as l-value (pythonGH-29866)  bpo-45476: Add _Py_RVALUE() macro (pythonGH-29860)  bpo-33381: [doc] strftime's %f option may pad zeros on the left or the right (pythonGH-29801)  Fix EncodingWarning in Tools/freeze/test/freeze.py (pythonGH-29742)  no-issue: remove unused import from test_graphlib.py (pythonGH-29853)  bpo-45931: Prevent Directory.Build.props/targets from leaking from directories above the repo when building on Windows (pythonGH-29854)  bpo-45653: fix test_embed on windows (pythonGH-29814)  bpo-45917: Add math.exp2() method - return 2 raised to the power of x (pythonGH-29829)  bpo-43905: Expand dataclasses.astuple() and asdict() docs (pythonGH-26154)  bpo-44391: Remove unused argument from a varargs call. (pythonGH-29843)  bpo-45881: configure --with-freeze-module --with-build-python (pythonGH-29835)  bpo-45847: PY_STDLIB_MOD_SIMPLE now checks py_stdlib_not_available (pythonGH-29844)  bpo-45828: Use unraisable exceptions within sqlite3 callbacks (FH-29591)  bpo-40280: Emscripten systems use .wasm suffix by default (pythonGH-29842)  bpo-45723: Sort the grand AC_CHECK_HEADERS check (pythonGH-29846)  bpo-45847: Make socket module conditional (pythonGH-29769)  ...
shihai1991 added a commit to shihai1991/cpython that referenced this pull requestDec 1, 2021
* main: (21 commits)  bpo-45876:  Have stdev() also use decimal specific square root. (pythonGH-29869)  bpo-45876:  Correctly rounded stdev() and pstdev() for the Decimal case (pythonGH-29828)  bpo-45711: Change exc_info related APIs to derive type and traceback from the exception instance (pythonGH-29780)  bpo-30533:Add function inspect.getmembers_static that does not call properties or dynamic properties. (python#20911)  bpo-45476: Disallow using asdl_seq_GET() as l-value (pythonGH-29866)  bpo-45476: Add _Py_RVALUE() macro (pythonGH-29860)  bpo-33381: [doc] strftime's %f option may pad zeros on the left or the right (pythonGH-29801)  Fix EncodingWarning in Tools/freeze/test/freeze.py (pythonGH-29742)  no-issue: remove unused import from test_graphlib.py (pythonGH-29853)  bpo-45931: Prevent Directory.Build.props/targets from leaking from directories above the repo when building on Windows (pythonGH-29854)  bpo-45653: fix test_embed on windows (pythonGH-29814)  bpo-45917: Add math.exp2() method - return 2 raised to the power of x (pythonGH-29829)  bpo-43905: Expand dataclasses.astuple() and asdict() docs (pythonGH-26154)  bpo-44391: Remove unused argument from a varargs call. (pythonGH-29843)  bpo-45881: configure --with-freeze-module --with-build-python (pythonGH-29835)  bpo-45847: PY_STDLIB_MOD_SIMPLE now checks py_stdlib_not_available (pythonGH-29844)  bpo-45828: Use unraisable exceptions within sqlite3 callbacks (FH-29591)  bpo-40280: Emscripten systems use .wasm suffix by default (pythonGH-29842)  bpo-45723: Sort the grand AC_CHECK_HEADERS check (pythonGH-29846)  bpo-45847: Make socket module conditional (pythonGH-29769)  ...
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Reviewers

@itamaroitamaroitamaro left review comments

@DinoVDinoVDinoV approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

6 participants
@hongweipeng@kernc@bedevere-bot@itamaro@DinoV@the-knights-who-say-ni

[8]ページ先頭

©2009-2025 Movatter.jp