Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

bpo-32604: Recommit "bpo-32604: PEP 554 for use in test suite (GH-19985)"#20611

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged

Conversation

@nanjekyejoannah
Copy link
Contributor

@nanjekyejoannahnanjekyejoannah commentedJun 3, 2020•
edited
Loading

Recommit of what was reverted in9d17cbf

The refleak in the select module was fixed in aseparate PR

With this fix, the tests pass:

gitpod /workspace/cpython $ ./python -m test -R 3:3 test_interpreters0:00:00 load avg: 4.74 Run tests sequentially0:00:00 load avg: 4.74 [1/1] test_interpretersbeginning 6 repetitions123456......test_interpreters passed in 1 min 9 sec== Tests result: SUCCESS ==1 test OK.Total duration: 1 min 9 secTests result: SUCCESS

https://bugs.python.org/issue32604

@vstinner
Copy link
Member

Sorry, I don't have the bandwidth to review this PR.

@nanjekyejoannah
Copy link
ContributorAuthor

The contents of this PR were already reviewed by@ericsnowcurrently . The only confirmation here is to confirm that no leaks make the tests fail which I already did. There are no changes to what had been merged before

@pablogsalpablogsal added the 🔨 test-with-buildbotsTest PR w/ buildbots; report in status section labelJun 3, 2020
@bedevere-bot
Copy link

🤖 New build scheduled with the buildbot fleet by@pablogsal for commit9577395 🤖

If you want to schedule another build, you need to add the ":hammer: test-with-buildbots" label again.

@bedevere-botbedevere-bot removed the 🔨 test-with-buildbotsTest PR w/ buildbots; report in status section labelJun 3, 2020
@pablogsal
Copy link
Member

pablogsal commentedJun 3, 2020•
edited
Loading

I didn't review this but I am confused....why there is anrst file with documentation in thetest directory?

@nanjekyejoannah
Copy link
ContributorAuthor

nanjekyejoannah commentedJun 3, 2020•
edited
Loading

@pablogsal, I think the discussion around this was Eric said we needed to have a reference to the added API intest.support. We could not add the document file inDoc/library/* before the API moved tostdlib. You can follow the discussion here:#19985

Edit:

I have looked and do not see docs anywhere else other than the Docs folder though. So am okay removing the.rst for this PR until consensus is reached.

ericsnowcurrently reacted with thumbs up emoji

@nanjekyejoannah
Copy link
ContributorAuthor

@pablogsal I decided to remove the docs. I hope this is okay now.

pablogsal reacted with thumbs up emoji

Copy link
Member

@ericsnowcurrentlyericsnowcurrently left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

LGTM As I said when I reviewed the original PR, this is a good start. :) Thanks for doing this.

Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

@pablogsalpablogsalpablogsal left review comments

@ericsnowcurrentlyericsnowcurrentlyericsnowcurrently approved these changes

@vstinnervstinnerAwaiting requested review from vstinner

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@nanjekyejoannah@vstinner@bedevere-bot@pablogsal@ericsnowcurrently@the-knights-who-say-ni
[8]ページ先頭
©2009-2025 Movatter.jp