NotificationsYou must be signed in to change notification settings
Fork32.4k
Star67.9k

bpo-40608: restore protection against double-deallocate issue for subclasses of classes that use trashcan#20104

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Jump to bottom

Closed

iritkatriel wants to merge1 commit intopython:mainfromiritkatriel:trashcan-regression

Closed

bpo-40608: restore protection against double-deallocate issue for subclasses of classes that use trashcan#20104

iritkatriel wants to merge1 commit intopython:mainfromiritkatriel:trashcan-regression

Conversation

Copy link

Member

iritkatriel commentedMay 15, 2020•
edited by bedevere-bot
Loading

Added a unit test that segfaults in python 3.8 and reversed the changes in typeobject.c that caused this segfault.

The segfault occurs with the old trashcan macros (Py_TRASHCAN_SAFE_BEGIN/END) and can be avoided by using the new ones (Py_TRASHCAN_BEGIN/END). The purpose of this change is to prevent segfaults in old code, it can be reversed once the old macros are removed.

https://bugs.python.org/issue40608

bpo-40608: restore protection against double-deallocate issue for sub…

3e076d6

…classes of classes that use trashcan

Copy link

the-knights-who-say-ni commentedMay 15, 2020

Hello, and thanks for your contribution!

I'm a bot set up to make sure that the project can legally accept this contribution by verifying everyone involved has signed thePSF contributor agreement (CLA).

CLA Missing

Our records indicate the following people have not signed the CLA:

@iritkatriel

For legal reasons we need all the people listed to sign the CLA before we can look at your contribution. Please followthe steps outlined in the CPython devguide to rectify this issue.

If you have recently signed the CLA, please wait at least one business day
before our records are updated.

You cancheck yourself to see if the CLA has been received.

Thanks again for the contribution, we look forward to reviewing it!