Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

WIP: PR created to test https://github.com/python/cpython/pull/19983#20096

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Closed
vstinner wants to merge1 commit intopython:masterfromvstinner:test_doc_change
Closed

WIP: PR created to test https://github.com/python/cpython/pull/19983#20096

vstinner wants to merge1 commit intopython:masterfromvstinner:test_doc_change

Conversation

@vstinner
Copy link
Member

No description provided.

@FFY00
Copy link
Member

We can add an|| true in the end so that github doesn't show the workflow as failed.

@vstinner
Copy link
MemberAuthor

We can add an || true in the end so that github doesn't show the workflow as failed.

@FFY00: Yeah, exactly. I just came up with the same idea :-) It would look better than "Some checks were not successful". Can you propose a PR to fix it?

@FFY00
Copy link
Member

Yes, I will do it in a bit. I'll ping you after to rebase this on top of it.

@vstinner
Copy link
MemberAuthor

By the way, usually I wrote||: rather than|| true. It's an old habit. It's a bash builtin function. I don't know if it's portable.|| true sounds more portable :-)

@FFY00
Copy link
Member

From what I gathered I think both: andtrue are bash builtins. Buttrue is also a POSIX binary (see/usr/bin/true).|| true is also more descriptive and doesn't require people to google what: is supposed to do :D

@ammaraskar
Copy link
Member

@vstinner
Copy link
MemberAuthor

PR rebased on top of commit6a78589 (GH-20097).

FFY00 and ammaraskar reacted with hooray emoji

@ammaraskar
Copy link
Member

12 seconds, looks good 👌

vstinner reacted with hooray emojivstinner and FFY00 reacted with rocket emoji

@vstinner
Copy link
MemberAuthor

Good: "Tests / Check for source changes (pull_request)" is no longer marked as failed, but "build" jobs continue to be skipped! Sadly, the reason for the skip is not mentioned :-( But it's ok, it's not a big deal. Most people are likely to not bother with it :-)
https://help.github.com/en/actions/reference/workflow-syntax-for-github-actions#jobsjob_idif

@FFY00
Copy link
Member

Yes, it would be good to be able to provide a reason but I don't really think it's that big of a deal :P As long as the devs are aware of this it should be perfectly fine.

@vstinnervstinner marked this pull request as ready for reviewMay 15, 2020 02:24
@vstinner
Copy link
MemberAuthor

Ok, great! I confirm that I get agreen merge button: I could merge the PR, even with skipped build jobs. Thanks again@FFY00 for fixing our CI config ;-)

I now close the issue since it proved that it works. (It doesn't prevent to merge a doc-only PR.)

@vstinnervstinner deleted the test_doc_change branchMay 15, 2020 02:30
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@vstinner@FFY00@ammaraskar@the-knights-who-say-ni@bedevere-bot

[8]ページ先頭

©2009-2025 Movatter.jp