Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork33.4k
WIP: PR created to test https://github.com/python/cpython/pull/19983#20096
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Uh oh!
There was an error while loading.Please reload this page.
Conversation
FFY00 commentedMay 14, 2020
We can add an |
vstinner commentedMay 14, 2020
@FFY00: Yeah, exactly. I just came up with the same idea :-) It would look better than "Some checks were not successful". Can you propose a PR to fix it? |
FFY00 commentedMay 15, 2020
Yes, I will do it in a bit. I'll ping you after to rebase this on top of it. |
vstinner commentedMay 15, 2020
By the way, usually I wrote |
FFY00 commentedMay 15, 2020
From what I gathered I think both |
ammaraskar commentedMay 15, 2020
vstinner commentedMay 15, 2020
ammaraskar commentedMay 15, 2020
12 seconds, looks good 👌 |
vstinner commentedMay 15, 2020
Good: "Tests / Check for source changes (pull_request)" is no longer marked as failed, but "build" jobs continue to be skipped! Sadly, the reason for the skip is not mentioned :-( But it's ok, it's not a big deal. Most people are likely to not bother with it :-) |
FFY00 commentedMay 15, 2020
Yes, it would be good to be able to provide a reason but I don't really think it's that big of a deal :P As long as the devs are aware of this it should be perfectly fine. |
vstinner commentedMay 15, 2020
Ok, great! I confirm that I get agreen merge button: I could merge the PR, even with skipped build jobs. Thanks again@FFY00 for fixing our CI config ;-) I now close the issue since it proved that it works. (It doesn't prevent to merge a doc-only PR.) |
No description provided.