Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

[WIP] bpo-40137: Use pep573 in functools extension module.#20055

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Closed

Conversation

@shihai1991
Copy link
Member

@shihai1991shihai1991 commentedMay 12, 2020•
edited by bedevere-bot
Loading

@shihai1991
Copy link
MemberAuthor

There have a problem what petr have mentioned in#19982: This also only works because the iterator type is not subclassable.(PyType_GetModule can not work if the type is subtype).

Copy link
Member

@vstinnervstinner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

It is possible to subclass lru_cache_type and so calling PyType_GetModule(Py_TYPE(self)) in lru_cache_new() doesn't work.

It seems like the _functools will have to wait until the PEP 573 is extended.

@bedevere-bot
Copy link

A Python core developer has requested some changes be made to your pull request before we can consider merging it. If you could please address their requests along with any other requests in other reviews from core developers that would be appreciated.

Once you have made the requested changes, please leave a comment on this pull request containing the phraseI have made the requested changes; please review again. I will then notify any core developers who have left a review that you're ready for them to take another look at this pull request.

@shihai1991
Copy link
MemberAuthor

It is possible to subclass lru_cache_type and so calling PyType_GetModule(Py_TYPE(self)) in lru_cache_new() doesn't work.

It seems like the _functools will have to wait until the PEP 573 is extended.

You are right, the type havetp_new can not worked now : (

Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

@vstinnervstinnervstinner requested changes

@encukouencukouencukou left review comments

@corona10corona10corona10 left review comments

@rhettingerrhettingerAwaiting requested review from rhettinger

Assignees

No one assigned

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@shihai1991@bedevere-bot@vstinner@encukou@corona10@the-knights-who-say-ni
[8]ページ先頭
©2009-2025 Movatter.jp