Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork32.1k
bpo-36543: Restore cElementTree and mark it for removal in 3.10#19921
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Uh oh!
There was an error while loading.Please reload this page.
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
LGTM.
Do we need a News entry for this? It's only reverting an alpha change.
Doc/whatsnew/3.9.rst Outdated
| @@ -616,6 +616,10 @@ Deprecated | |||
| `parso`_. | |||
| (Contributed by Carl Meyer in :issue:`40360`.) | |||
| * The :mod:`xml.etree.cElementTree` module has been deprecated since Python | |||
| 3.3 and is scheduled to be removed in Python 3.10. | |||
| (Contributed by Serhiy Storchaka and Christian Heemes in :issue:`36543`) | |||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
A typo in your own name? That's rare, I guess. ;-)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
You wouldn't believe me 👍
| _warn( | ||
| "xml.etree.cElementTree is deprecated, use xml.etree.ElementTree instead", | ||
| PendingDeprecationWarning | ||
| ) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
| ) | |
| ) | |
| del_warn |
Let's got withGH-19920 instead, shall we? |
This reverts commitb33e525.
Signed-off-by: Christian Heimes <christian@python.org>
With 3.9 branch created the PR pointed to master will go in for 3.10. |
It's been deprecated and will be removed in 3.9 or 3.10. 3.9.0b1 doesn'thave cElementTree. I'd like to bring it back with a deprecation warningto drop in 3.10.See:python/cpython#19921Signed-off-by: Christian Heimes <christian@python.org>
| @@ -626,6 +626,10 @@ Deprecated | |||
| `parso`_. | |||
| (Contributed by Carl Meyer in :issue:`40360`.) | |||
| * The :mod:`xml.etree.cElementTree` module has been deprecated since Python | |||
| 3.3 and is scheduled to be removed in Python 3.10. | |||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Use more direct wording:
- clearer
- similar to that in xml.etree.elementtree.rst
- fewer words = more readable
| 3.3 andis scheduled to be removed in Python 3.10. | |
| 3.3 andwill be removed in Python 3.10. |
It's been deprecated and will be removed in 3.9 or 3.10. 3.9.0b1 doesn'thave cElementTree. I'd like to bring it back with a deprecation warningto drop in 3.10.See:python/cpython#19921Signed-off-by: Christian Heimes <christian@python.org>Signed-off-by: Sam Sneddon <me@gsnedders.com>
I merged#20117, which reverts the removal. |
It's been deprecated and will be removed in 3.9 or 3.10. 3.9.0b1 doesn'thave cElementTree. I'd like to bring it back with a deprecation warningto drop in 3.10.See:python/cpython#19921Signed-off-by: Christian Heimes <christian@python.org>Signed-off-by: Sam Sneddon <me@gsnedders.com>
It's been deprecated and will be removed in 3.9 or 3.10. 3.9.0b1 doesn'thave cElementTree. I'd like to bring it back with a deprecation warningto drop in 3.10.See:python/cpython#19921Signed-off-by: Christian Heimes <christian@python.org>Signed-off-by: Sam Sneddon <me@gsnedders.com>
Uh oh!
There was an error while loading.Please reload this page.
xml.etree.cElementTreePendingDeprecationWarninghttps://bugs.python.org/issue36543