Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

bpo-40443: Remove unused imports in idlelib#19801

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
terryjreedy merged 1 commit intopython:masterfromvstinner:remove_unused_imports_idle
Apr 30, 2020
Merged

bpo-40443: Remove unused imports in idlelib#19801

terryjreedy merged 1 commit intopython:masterfromvstinner:remove_unused_imports_idle
Apr 30, 2020

Conversation

@vstinner
Copy link
Member

@vstinnervstinner commentedApr 29, 2020•
edited by bedevere-bot
Loading

@vstinner
Copy link
MemberAuthor

@terryjreedy@csabella: Would you mind to review this PR?

Copy link
Member

@terryjreedyterryjreedy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Non-use verified.

@terryjreedy
Copy link
Member

Don't understand macOS failure, and the abrupt stop. Treating as unrelated intermittent failure.

clang: warning: -framework Tk: 'linker' input unused [-Wunused-command-line-argument]In file included from /Users/runner/runners/2.169.1/work/cpython/cpython/Modules/_tkinter.c:46:/Applications/Xcode_11.3.1.app/Contents/Developer/Platforms/MacOSX.platform/Developer/SDKs/MacOSX.sdk/usr/include/tk.h:86:11: fatal error: 'X11/Xlib.h' file not found#       include <X11/Xlib.h>                ^~~~~~~~~~~~1 error generated.Python build finished successfully!...The following modules found by detect_modules() in setup.py, have been

...

@miss-islington
Copy link
Contributor

Thanks@vstinner for the PR, and@terryjreedy for merging it 🌮🎉.. I'm working now to backport this PR to: 3.7.
🐍🍒⛏🤖

@miss-islington
Copy link
Contributor

Thanks@vstinner for the PR, and@terryjreedy for merging it 🌮🎉.. I'm working now to backport this PR to: 3.8.
🐍🍒⛏🤖

miss-islington pushed a commit to miss-islington/cpython that referenced this pull requestApr 30, 2020
(cherry picked from commit6900f16)Co-authored-by: Victor Stinner <vstinner@python.org>
@bedevere-bot
Copy link

GH-19808 is a backport of this pull request to the3.7 branch.

miss-islington pushed a commit to miss-islington/cpython that referenced this pull requestApr 30, 2020
(cherry picked from commit6900f16)Co-authored-by: Victor Stinner <vstinner@python.org>
@bedevere-bot
Copy link

GH-19809 is a backport of this pull request to the3.8 branch.

miss-islington added a commit that referenced this pull requestApr 30, 2020
(cherry picked from commit6900f16)Co-authored-by: Victor Stinner <vstinner@python.org>
miss-islington added a commit that referenced this pull requestApr 30, 2020
(cherry picked from commit6900f16)Co-authored-by: Victor Stinner <vstinner@python.org>
@vstinnervstinner deleted the remove_unused_imports_idle branchApril 30, 2020 09:29
@vstinner
Copy link
MemberAuthor

Terry: yeah sadly the macOS CI looks sick :-(

Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

@terryjreedyterryjreedyterryjreedy approved these changes

@csabellacsabellaAwaiting requested review from csabella

Assignees

No one assigned

Labels

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@vstinner@terryjreedy@miss-islington@bedevere-bot@the-knights-who-say-ni
[8]ページ先頭
©2009-2025 Movatter.jp