NotificationsYou must be signed in to change notification settings
Fork32.1k
Star67.4k

gh-71807: The escape key closes IDLE's config dialog as canceled#19706

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Jump to bottom

Open

ZackerySpytz wants to merge2 commits intopython:main

base:main

Choose a base branch

fromZackerySpytz:bpo-27620-IDLE-escape-key-config

Open

gh-71807: The escape key closes IDLE's config dialog as canceled#19706

ZackerySpytz wants to merge2 commits intopython:mainfromZackerySpytz:bpo-27620-IDLE-escape-key-config

Conversation

Copy link

Contributor

ZackerySpytz commentedApr 25, 2020•
edited by terryjreedy
Loading

Issue:IDLE: Add keyboard equivalents for mouse actions. #71807

bpo-27620: The escape key closes IDLE's config dialog as canceled

71c0f7a

ZackerySpytz requested a review fromterryjreedy as acode owner

April 25, 2020 00:59

the-knights-who-say-ni added the CLA signed label

Apr 25, 2020

bedevere-bot added the awaiting review label

Apr 25, 2020

Copy link

ContributorAuthor

ZackerySpytz commentedApr 25, 2020

I think the escape key binding should be enabled, but I'm not so sure about the other ones.

ezio-melotti removed the CLA signed label

Jul 13, 2022

terryjreedy changed the title~~bpo-27620: The escape key closes IDLE's config dialog as canceled~~gh-71807: The escape key closes IDLE's config dialog as canceled

Sep 18, 2022

Merge branch 'main' into bpo-27620-IDLE-escape-key-config

e03b993

terryjreedy reviewed

Sep 18, 2022

View reviewed changes

Copy link

Member

terryjreedy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

PR title and blurb only refer to Escape to exit (cancel). I may limit PR to this, but expand to subsidiary dialogs that are not query boxes. (Should check code since it works.)

If there is a key for [Apply], there should be a key for [OK].
Ctrl-Enter and Alt-Enter might be a good pair.

Tab navigation has multiple problems: Never gets to these buttons.
Tabbing into font sample traps focus on the text widget.
Some widgets get skipped.

Other key bindings are needed: No way to toggle button or select radio button.

Changes are needed, but I am not sure which to do at the moment.