Thanks@methane ! I've replied to your comments with updated suggestions to reflect your feedback.

I will merge this PR next week if there are no objections.

⚠️⚠️⚠️ Buildbot failure⚠️⚠️⚠️

Hi! The buildbotAMD64 RHEL7 LTO + PGO 3.x has failed when building commit4827483.

What do you need to do:

1. Don't panic.
2. Checkthe buildbot page in the devguide if you don't know what the buildbots are or how they work.
3. Go to the page of the buildbot that failed (https://buildbot.python.org/all/#builders/96/builds/910) and take a look at the build logs.
4. Check if the failure is related to this commit (4827483) or if it is a false positive.
5. If the failure is related to this commit, please, reflect that on the issue and make a new Pull Request with a fix.

You can take a look at the buildbot page here:

https://buildbot.python.org/all/#builders/96/builds/910

Failed tests:

• test_tools
• test_ftplib

Failed subtests:

• test_storlines - test.test_ftplib.TestFTPClass
• test_reindent_file_with_bad_encoding - test.test_tools.test_reindent.ReindentTests

Summary of the results of the build (if available):

== Tests result: FAILURE then FAILURE ==

412 tests OK.

10 slowest tests:

• test_concurrent_futures: 2 min 38 sec
• test_shelve: 2 min 30 sec
• test_mailbox: 1 min 57 sec
• test_dbm: 1 min 52 sec
• test_tarfile: 1 min 36 sec
• test_multiprocessing_spawn: 1 min 34 sec
• test_tokenize: 1 min 33 sec
• test_dbm_gnu: 1 min 28 sec
• test_unparse: 1 min 28 sec
• test_asyncio: 1 min 17 sec

1 test failed:
test_tools

14 tests skipped:
test_devpoll test_gdb test_ioctl test_kqueue test_msilib
test_ossaudiodev test_startfile test_tix test_tk test_ttk_guionly
test_winconsoleio test_winreg test_winsound test_zipfile64

2 re-run tests:
test_ftplib test_tools

Total duration: 6 min 19 sec

Traceback (most recent call last):  File"/home/buildbot/buildarea/3.x.cstratak-RHEL7-x86_64.lto-pgo/build/Lib/test/test_ftplib.py", line623, intest_storlinesself.check_data(self.server.handler_instance.last_received_data,RETR_DATA)  File"/home/buildbot/buildarea/3.x.cstratak-RHEL7-x86_64.lto-pgo/build/Lib/test/test_ftplib.py", line494, incheck_dataself.assertEqual(len(received),len(expected))AssertionError:12019 != 12018Traceback (most recent call last):  File"/home/buildbot/buildarea/3.x.cstratak-RHEL7-x86_64.lto-pgo/build/Lib/test/test_tools/test_reindent.py", line29, intest_reindent_file_with_bad_encoding    rc, out, err= assert_python_ok(self.script,'-r', bad_coding_path)  File"/home/buildbot/buildarea/3.x.cstratak-RHEL7-x86_64.lto-pgo/build/Lib/test/support/script_helper.py", line160, inassert_python_okreturn _assert_python(True,*args,**env_vars)  File"/home/buildbot/buildarea/3.x.cstratak-RHEL7-x86_64.lto-pgo/build/Lib/test/support/script_helper.py", line145, in_assert_python    res.fail(cmd_line)  File"/home/buildbot/buildarea/3.x.cstratak-RHEL7-x86_64.lto-pgo/build/Lib/test/support/script_helper.py", line72, infailraiseAssertionError("Process return code is%d\n"AssertionError:Process return code is 1command line: ['/home/buildbot/buildarea/3.x.cstratak-RHEL7-x86_64.lto-pgo/build/python', '-X', 'faulthandler', '-I', '/home/buildbot/buildarea/3.x.cstratak-RHEL7-x86_64.lto-pgo/build/Tools/scripts/reindent.py', '-r', '/home/buildbot/buildarea/3.x.cstratak-RHEL7-x86_64.lto-pgo/build/Lib/test/bad_coding.py']

⚠️⚠️⚠️ Buildbot failure⚠️⚠️⚠️

Hi! The buildbotAMD64 RHEL7 LTO 3.x has failed when building commit4827483.

What do you need to do:

1. Don't panic.
2. Checkthe buildbot page in the devguide if you don't know what the buildbots are or how they work.
3. Go to the page of the buildbot that failed (https://buildbot.python.org/all/#builders/507/builds/896) and take a look at the build logs.
4. Check if the failure is related to this commit (4827483) or if it is a false positive.
5. If the failure is related to this commit, please, reflect that on the issue and make a new Pull Request with a fix.

You can take a look at the buildbot page here:

https://buildbot.python.org/all/#builders/507/builds/896

Failed tests:

• test_tools

Failed subtests:

• test_reindent_file_with_bad_encoding - test.test_tools.test_reindent.ReindentTests

Summary of the results of the build (if available):

== Tests result: FAILURE then FAILURE ==

412 tests OK.

10 slowest tests:

• test_mailbox: 4 min 33 sec
• test_peg_generator: 3 min 37 sec
• test_concurrent_futures: 2 min 56 sec
• test_shelve: 2 min 27 sec
• test_multiprocessing_spawn: 1 min 50 sec
• test_tokenize: 1 min 49 sec
• test_unparse: 1 min 37 sec
• test_lib2to3: 1 min 25 sec
• test_asyncio: 1 min 21 sec
• test_multiprocessing_forkserver: 1 min 9 sec

1 test failed:
test_tools

14 tests skipped:
test_devpoll test_gdb test_ioctl test_kqueue test_msilib
test_ossaudiodev test_startfile test_tix test_tk test_ttk_guionly
test_winconsoleio test_winreg test_winsound test_zipfile64

1 re-run test:
test_tools

Total duration: 7 min 15 sec

Traceback (most recent call last):  File"/home/buildbot/buildarea/3.x.cstratak-RHEL7-x86_64.lto/build/Lib/test/test_tools/test_reindent.py", line29, intest_reindent_file_with_bad_encoding    rc, out, err= assert_python_ok(self.script,'-r', bad_coding_path)  File"/home/buildbot/buildarea/3.x.cstratak-RHEL7-x86_64.lto/build/Lib/test/support/script_helper.py", line160, inassert_python_okreturn _assert_python(True,*args,**env_vars)  File"/home/buildbot/buildarea/3.x.cstratak-RHEL7-x86_64.lto/build/Lib/test/support/script_helper.py", line145, in_assert_python    res.fail(cmd_line)  File"/home/buildbot/buildarea/3.x.cstratak-RHEL7-x86_64.lto/build/Lib/test/support/script_helper.py", line72, infailraiseAssertionError("Process return code is%d\n"AssertionError:Process return code is 1command line: ['/home/buildbot/buildarea/3.x.cstratak-RHEL7-x86_64.lto/build/python', '-X', 'faulthandler', '-I', '/home/buildbot/buildarea/3.x.cstratak-RHEL7-x86_64.lto/build/Tools/scripts/reindent.py', '-r', '/home/buildbot/buildarea/3.x.cstratak-RHEL7-x86_64.lto/build/Lib/test/bad_coding.py']

⚠️⚠️⚠️ Buildbot failure⚠️⚠️⚠️

Hi! The buildbotAMD64 Windows10 3.x has failed when building commit4827483.

What do you need to do:

1. Don't panic.
2. Checkthe buildbot page in the devguide if you don't know what the buildbots are or how they work.
3. Go to the page of the buildbot that failed (https://buildbot.python.org/all/#builders/146/builds/1014) and take a look at the build logs.
4. Check if the failure is related to this commit (4827483) or if it is a false positive.
5. If the failure is related to this commit, please, reflect that on the issue and make a new Pull Request with a fix.

You can take a look at the buildbot page here:

https://buildbot.python.org/all/#builders/146/builds/1014

Failed tests:

• test_locale

Failed subtests:

• test_getsetlocale_issue1813 - test.test_locale.TestMiscellaneous

Summary of the results of the build (if available):

== Tests result: FAILURE then FAILURE ==

395 tests OK.

10 slowest tests:

• test_mmap: 9 min 37 sec
• test_largefile: 5 min 57 sec
• test_io: 5 min 39 sec
• test_unparse: 3 min 12 sec
• test_multiprocessing_spawn: 2 min 16 sec
• test_concurrent_futures: 2 min 3 sec
• test_tokenize: 1 min 46 sec
• test_capi: 1 min 46 sec
• test_peg_generator: 1 min 39 sec
• test_asyncio: 1 min 31 sec

1 test failed:
test_locale

31 tests skipped:
test_curses test_dbm_gnu test_dbm_ndbm test_devpoll test_epoll
test_fcntl test_fork1 test_gdb test_grp test_ioctl test_kqueue
test_multiprocessing_fork test_multiprocessing_forkserver test_nis
test_openpty test_ossaudiodev test_pipes test_poll test_posix
test_pty test_pwd test_readline test_resource test_spwd
test_syslog test_threadsignals test_wait3 test_wait4
test_xxlimited test_xxtestfuzz test_zipfile64

1 re-run test:
test_locale

Total duration: 19 min 35 sec

Traceback (most recent call last):  File"D:\buildarea\3.x.bolen-windows10\build\lib\test\test_locale.py", line567, intest_getsetlocale_issue1813    locale.setlocale(locale.LC_CTYPE, loc)  File"D:\buildarea\3.x.bolen-windows10\build\lib\locale.py", line610, insetlocalereturn _setlocale(category, locale)locale.Error:unsupported locale setting

test_locale fail is unrelating to this PR. Seebpo-37945.

Thanks@methane ! Excited to see this in Python 3.10.