Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

bpo-35037 Fix issue in cython project: Cython files don't compile on Mingw-w64 64-bit#19326

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Closed

Conversation

BenjaminLiuPenrose
Copy link

@BenjaminLiuPenroseBenjaminLiuPenrose commentedApr 3, 2020
edited by bedevere-bot
Loading

Reference Issues/PRs

bpo-40167https://bugs.python.org/issue40167
fixes cython project issue incython/cython#3405

What does this implement/fix? Explain your changes.

fix Cython files don't compile on Mingw-w64 64-bit problem

https://bugs.python.org/issue40167

@the-knights-who-say-ni

Hello, and thanks for your contribution!

I'm a bot set up to make sure that the project can legally accept this contribution by verifying everyone involved has signed thePSF contributor agreement (CLA).

Recognized GitHub username

We couldn't find abugs.python.org (b.p.o) account corresponding to the following GitHub usernames:

@BenjaminLiuPenrose

This might be simply due to a missing "GitHub Name" entry in one's b.p.o account settings. This is necessary for legal reasons before we can look at this contribution. Please followthe steps outlined in the CPython devguide to rectify this issue.

You cancheck yourself to see if the CLA has been received.

Thanks again for the contribution, we look forward to reviewing it!

@BenjaminLiuPenroseBenjaminLiuPenrose changed the titleFix issue in cython project: Cython files don't compile on Mingw-w64 64-bitbpo-40167 Fix issue in cython project: Cython files don't compile on Mingw-w64 64-bitApr 3, 2020
@BenjaminLiuPenrose
Copy link
Author

Hi, I already signed CLA with my github account

Comment on lines +2 to +3
Add Mingw-w64 64-bit windows machine, fix issue
in https://bugs.python.org/issue40167
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

You'll need to create a new NEWS entry file rather than adding this to an existing one. Useblurb-it orblurb.

@@ -78,6 +78,11 @@ WIN32 is still required for the locale module.


/* Compiler specific defines */
#ifdef __MINGW32__
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Please add a comment explaining why and when this is needed.

@bedevere-bot
Copy link

A Python core developer has requested some changes be made to your pull request before we can consider merging it. If you could please address their requests along with any other requests in other reviews from core developers that would be appreciated.

Once you have made the requested changes, please leave a comment on this pull request containing the phraseI have made the requested changes; please review again. I will then notify any core developers who have left a review that you're ready for them to take another look at this pull request.

@iritkatrieliritkatriel changed the titlebpo-40167 Fix issue in cython project: Cython files don't compile on Mingw-w64 64-bitbpo-35037 Fix issue in cython project: Cython files don't compile on Mingw-w64 64-bitOct 20, 2021
@iritkatriel
Copy link
Member

iritkatriel commentedOct 20, 2021
edited by bedevere-bot
Loading

Closedbpo-40167 as a duplicate of an olderbpo-35037 which has more info. Please update the PR as requested by@taleinat

@jimboyeah
Copy link

You should specify-DMS_WIN64 forg++ to using MinGW-64 on Windows.

1 similar comment
@jimboyeah
Copy link

You should specify-DMS_WIN64 forg++ to using MinGW-64 on Windows.

@taleinat
Copy link
Contributor

taleinat commentedApr 7, 2022
edited
Loading

The original author hasn't picked this up again since my comments 1.5 years ago. I think we can consider them no longer interested.

Is anyone else interested in bringing this to completion?@jimboyeah?

@rgommers
Copy link
Contributor

This PR can be closed, it was superceded bygh-100137 which was merged 2 months ago.

@arhadthedev
Copy link
Member

@rgommers Thank you for pointing the duplicate out! Closing.

Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Reviewers

@taleinattaleinattaleinat requested changes

Assignees
No one assigned
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

10 participants
@BenjaminLiuPenrose@the-knights-who-say-ni@bedevere-bot@iritkatriel@jimboyeah@taleinat@rgommers@arhadthedev@csabella@ezio-melotti

[8]ページ先頭

©2009-2025 Movatter.jp