Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork32.1k
bpo-35037 Fix issue in cython project: Cython files don't compile on Mingw-w64 64-bit#19326
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Uh oh!
There was an error while loading.Please reload this page.
Conversation
the-knights-who-say-ni commentedApr 3, 2020
Hello, and thanks for your contribution! I'm a bot set up to make sure that the project can legally accept this contribution by verifying everyone involved has signed thePSF contributor agreement (CLA). Recognized GitHub usernameWe couldn't find abugs.python.org (b.p.o) account corresponding to the following GitHub usernames: This might be simply due to a missing "GitHub Name" entry in one's b.p.o account settings. This is necessary for legal reasons before we can look at this contribution. Please followthe steps outlined in the CPython devguide to rectify this issue. You cancheck yourself to see if the CLA has been received. Thanks again for the contribution, we look forward to reviewing it! |
Hi, I already signed CLA with my github account |
Add Mingw-w64 64-bit windows machine, fix issue | ||
in https://bugs.python.org/issue40167 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
@@ -78,6 +78,11 @@ WIN32 is still required for the locale module. | |||
/* Compiler specific defines */ | |||
#ifdef __MINGW32__ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Please add a comment explaining why and when this is needed.
bedevere-bot commentedSep 26, 2020
A Python core developer has requested some changes be made to your pull request before we can consider merging it. If you could please address their requests along with any other requests in other reviews from core developers that would be appreciated. Once you have made the requested changes, please leave a comment on this pull request containing the phrase |
iritkatriel commentedOct 20, 2021 • edited by bedevere-bot
Loading Uh oh!
There was an error while loading.Please reload this page.
edited by bedevere-bot
Uh oh!
There was an error while loading.Please reload this page.
jimboyeah commentedApr 7, 2022
You should specify |
1 similar comment
jimboyeah commentedApr 7, 2022
You should specify |
taleinat commentedApr 7, 2022 • edited
Loading Uh oh!
There was an error while loading.Please reload this page.
edited
Uh oh!
There was an error while loading.Please reload this page.
The original author hasn't picked this up again since my comments 1.5 years ago. I think we can consider them no longer interested. Is anyone else interested in bringing this to completion?@jimboyeah? |
This PR can be closed, it was superceded bygh-100137 which was merged 2 months ago. |
@rgommers Thank you for pointing the duplicate out! Closing. |
Uh oh!
There was an error while loading.Please reload this page.
Reference Issues/PRs
bpo-40167https://bugs.python.org/issue40167
fixes cython project issue incython/cython#3405
What does this implement/fix? Explain your changes.
fix Cython files don't compile on Mingw-w64 64-bit problem
https://bugs.python.org/issue40167