Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

gh-83915: Deprecate the readinto() fallback path in _pickle.c#19237

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Open
ZackerySpytz wants to merge4 commits intopython:main
base:main
Choose a base branch
Loading
fromZackerySpytz:bpo-39734-readinto-pickle-depr

Conversation

ZackerySpytz
Copy link
Contributor

@ZackerySpytzZackerySpytz commentedMar 30, 2020•
edited by bedevere-appbot
Loading

@ZackerySpytz
Copy link
ContributorAuthor

I think the warning message could be better.
This PR still needs a news entry (if it is accepted).

pitrou
pitrou previously requested changesApr 18, 2020
Copy link
Member

@pitroupitrou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Thank you for doing this. It looks good on the principle.

@bedevere-bot
Copy link

A Python core developer has requested some changes be made to your pull request before we can consider merging it. If you could please address their requests along with any other requests in other reviews from core developers that would be appreciated.

Once you have made the requested changes, please leave a comment on this pull request containing the phraseI have made the requested changes; please review again. I will then notify any core developers who have left a review that you're ready for them to take another look at this pull request.

@iritkatriel
Copy link
Member

I have made the requested changes; please review again.

Copy link
Member

@iritkatrieliritkatriel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

With the change the test fails for the Python version unpickler:

======================================================================FAIL: test_multiple_unpicklings_minimal (test.test_pickle.PyPicklerUnpicklerObjectTests.test_multiple_unpicklings_minimal)----------------------------------------------------------------------Traceback (most recent call last):  File "/Users/iritkatriel/src/cpython/Lib/test/pickletester.py", line 3710, in test_multiple_unpicklings_minimal    with self.assertWarns(DeprecationWarning):AssertionError: DeprecationWarning not triggered

@bedevere-bot
Copy link

A Python core developer has requested some changes be made to your pull request before we can consider merging it. If you could please address their requests along with any other requests in other reviews from core developers that would be appreciated.

Once you have made the requested changes, please leave a comment on this pull request containing the phraseI have made the requested changes; please review again. I will then notify any core developers who have left a review that you're ready for them to take another look at this pull request.

@erlend-aaslanderlend-aasland changed the titlebpo-39734: Deprecate the readinto() fallback path in _pickle.cgh-83915: Deprecate the readinto() fallback path in _pickle.cJan 5, 2024
@python-cla-bot
Copy link

python-cla-botbot commentedApr 18, 2025•
edited
Loading

All commit authors signed the Contributor License Agreement.

CLA signed

Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Reviewers

@iritkatrieliritkatrieliritkatriel requested changes

@pitroupitroupitrou left review comments

Assignees
No one assigned
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

8 participants
@ZackerySpytz@bedevere-bot@iritkatriel@pitrou@the-knights-who-say-ni@ezio-melotti@AlexWaygood@erlend-aasland
[8]ページ先頭
©2009-2025 Movatter.jp