Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork33.3k
Rename Doc/README.txt to Doc/README.rst#19
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Uh oh!
There was an error while loading.Please reload this page.
Conversation
the-knights-who-say-ni commentedFeb 11, 2017
Hello, and thanks for your contribution! I'm a bot set up to make sure that the project can legally accept your contribution by verifying you have signed thePSF contributor agreement (CLA). Unfortunately our records indicate you have not signed the CLA. For legal reasons we need you to sign this before we can look at your contribution. Please follow these steps to rectify the issue:
Thanks again to your contribution and we look forward to looking at it! |
| echo. | ||
| echo.All arguments past the first one are passed through to sphinx-build as | ||
| echo.filenames to build or are ignored. See README.txt in this directory or | ||
| echo.filenames to build or are ignored. See README.rst in this directory or |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Doc/README.txt is still alive.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
This PR renames Doc/README.txt to Doc/README.rst.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Ah, I'm sorry. I misundersttod.
| echo. | ||
| echo.All arguments past the first one are passed through to sphinx-build as | ||
| echo.filenames to build or are ignored. See README.txt in this directory or | ||
| echo.filenames to build or are ignored. See README.rst in this directory or |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Ah, I'm sorry. I misundersttod.
methane commentedFeb 11, 2017
I think we don't require CLA sign for pull requests like this. |
orsenthil commentedFeb 11, 2017
@methane , any patch / contribution requires CLA sign. |
ghost commentedFeb 11, 2017
I signed it an hour ago. |
methane commentedFeb 11, 2017
|
vstinner left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
I suggest to take the opportunity of this change to not only rename README.txt to README.rst but also make some reST syntax enhancements like using reST syntax for links.
ghost commentedFeb 12, 2017 • edited by ghost
Loading Uh oh!
There was an error while loading.Please reload this page.
edited by ghost
Uh oh!
There was an error while loading.Please reload this page.
@methane MY CLA still has not been marked, and I currently have this:
It's been two days since I submitted it, any update? |
vstinner commentedFeb 12, 2017
Why was this change tagged as "backport to 3.6"? Was it made in the 3.6 branch? If yes, please redo it in the master branch. |
ghost commentedFeb 12, 2017
No, it was made in the master branch@Haypo |
ghost commentedFeb 12, 2017
@Haypo Can you give me an example as to how you would like the link formatted? I'm more used to writing in markdown than I am in reST |
vstinner commentedFeb 13, 2017
Look at README.rst in the root directory. |
vstinner left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
I suggested different text where [...] is the link.
Doc/README.rst Outdated
| Bugs in the toolset should be reported in the Sphinx bug tracker at | ||
| https://www.bitbucket.org/birkenfeld/sphinx/issues/. | ||
| `bitbucket.org/birkenfeld/sphinx/issues/<https://www.bitbucket.org/birkenfeld/sphinx/issues/>`_. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
I suggest "Bugs in the toolset should be reported in the [Sphinx bug tracker]."
Doc/README.rst Outdated
| Contributing | ||
| ============ | ||
| Bugs in the content should be reported to the Python bug tracker at |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
"Bugs in the content should be reported to the [Python bug tracker]."
Doc/README.rst Outdated
| You need to have`Sphinx<http://sphinx-doc.org/>`_ installed; it is the toolset | ||
| used to build the docs. It is not included in this tree, but maintained | ||
| separately and available from PyPI <https://pypi.python.org/pypi/Sphinx>. | ||
| separately and available from`PyPI<https://pypi.python.org/pypi/Sphinx>`_. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
and [available from PyPI].
Doc/README.rst Outdated
| This directory contains the reStructuredText (reST) sources to the Python | ||
| documentation. You don't need to build them yourself, prebuilt versions are | ||
| available at <https://docs.python.org/dev/download.html>. | ||
| available at`docs.python.org/dev/download.html<https://docs.python.org/dev/download.html>`_. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
..., [prebuilt versions are available].
ghost commentedFeb 13, 2017 • edited by ghost
Loading Uh oh!
There was an error while loading.Please reload this page.
edited by ghost
Uh oh!
There was an error while loading.Please reload this page.
The reason the CLA bot is not showing me as signed is probably because I used the online editor for the original commit (which commits under the noreply@github address). My email address is |
Codecov Report
@@ Coverage Diff @@## master #19 +/- ##==========================================- Coverage 82.37% 82.37% -0.01%========================================== Files 1427 1427 Lines 350948 350948 ==========================================- Hits 289091 289089 -2- Misses 61857 61859 +2 Continue to review full report at Codecov.
|
ghost commentedFeb 13, 2017
@Haypo The changes you requested were made |
ghost commentedFeb 13, 2017
It is still not showing up on my account! I have filed a new one for each day it has not been added. |
berkerpeksag commentedFeb 13, 2017
Please note that the PSF is based in the United States and they can only process CLA requests in workdays. |
ghost commentedFeb 15, 2017
I am moving this PR soon now that my CLA is confirmed and due to overlaps with the master branch. |
ghost commentedFeb 15, 2017
Moved to#104 and my CLA is now processed |
Fix venvlauncher
19: Warn for range and xrange r=ltratt a=nanjekyejoannahSee notes:```Py2.x:>>> x = xrange(1, 10000)>>> a = range(1,10000)>>> type(a)<type 'list'>>>> Py3.x:>>> x = xrange(1, 10000)Traceback (most recent call last): File "<stdin>", line 1, in <module>NameError: name 'xrange' is not defined>>> a = range(1,10000)>>> type(a)<class 'range'>>>> ```Co-authored-by: Joannah Nanjekye <jnanjekye@python.org>
* fix: off by one error in forward jump calculation* Test: fixed test forpython#18* test: remove broken test---------Co-authored-by: Jules <julia.poo.poo.poo@gmail.com>
I have simply updated the document and its references to README.rst (thanks to whoever formatted it).