Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

Rename Doc/README.txt to Doc/README.rst#19

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Closed
ghost wants to merge5 commits intopython:masterfromunknown repository
Closed

Rename Doc/README.txt to Doc/README.rst#19

ghost wants to merge5 commits intopython:masterfromunknown repository

Conversation

ghost
Copy link

I have simply updated the document and its references to README.rst (thanks to whoever formatted it).

@the-knights-who-say-ni

Hello, and thanks for your contribution!

I'm a bot set up to make sure that the project can legally accept your contribution by verifying you have signed thePSF contributor agreement (CLA).

Unfortunately our records indicate you have not signed the CLA. For legal reasons we need you to sign this before we can look at your contribution. Please follow these steps to rectify the issue:

  1. Sign thePSF contributor agreement
  2. Wait at least a day and then check "Your Details" onbugs.python.org to see if your account has been marked as having signed the CLA (the delay is due to a person having to manually check your signed CLA)
  3. Reply here saying you have completed the above steps

Thanks again to your contribution and we look forward to looking at it!

@@ -74,7 +74,7 @@ echo. Provided by this script:
echo. clean, check, serve, htmlview
echo.
echo.All arguments past the first one are passed through to sphinx-build as
echo.filenames to build or are ignored. See README.txt in this directory or
echo.filenames to build or are ignored. See README.rst in this directory or
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Doc/README.txt is still alive.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

This PR renames Doc/README.txt to Doc/README.rst.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Ah, I'm sorry. I misundersttod.

@@ -74,7 +74,7 @@ echo. Provided by this script:
echo. clean, check, serve, htmlview
echo.
echo.All arguments past the first one are passed through to sphinx-build as
echo.filenames to build or are ignored. See README.txt in this directory or
echo.filenames to build or are ignored. See README.rst in this directory or
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Ah, I'm sorry. I misundersttod.

@methane
Copy link
Member

I think we don't require CLA sign for pull requests like this.

@orsenthil
Copy link
Member

@methane , any patch / contribution requires CLA sign.

@ghost
Copy link
Author

I signed it an hour ago.

@methane
Copy link
Member

Wait at least a day and then check "Your Details" on bugs.python.org to see if your account has been marked as having signed the CLA (the delay is due to a person having to manually check your signed CLA)

Copy link
Member

@vstinnervstinner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

I suggest to take the opportunity of this change to not only rename README.txt to README.rst but also make some reST syntax enhancements like using reST syntax for links.

@ghost
Copy link
Author

ghost commentedFeb 12, 2017•
edited by ghost
Loading

@methane MY CLA still has not been marked, and I currently have this:

image

It's been two days since I submitted it, any update?

@vstinner
Copy link
Member

Why was this change tagged as "backport to 3.6"? Was it made in the 3.6 branch? If yes, please redo it in the master branch.

@ghost
Copy link
Author

No, it was made in the master branch@Haypo

@ghost
Copy link
Author

@Haypo Can you give me an example as to how you would like the link formatted? I'm more used to writing in markdown than I am in reST

@vstinner
Copy link
Member

@Haypo Can you give me an example as to how you would like the link formatted? I'm more used to writing in markdown than I am in reST

Look at README.rst in the root directory.

Copy link
Member

@vstinnervstinner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

I suggested different text where [...] is the link.


Bugs in the toolset should be reported in the Sphinx bug tracker at
https://www.bitbucket.org/birkenfeld/sphinx/issues/.
`bitbucket.org/birkenfeld/sphinx/issues/ <https://www.bitbucket.org/birkenfeld/sphinx/issues/>`_.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

I suggest "Bugs in the toolset should be reported in the [Sphinx bug tracker]."

@@ -109,10 +109,10 @@ Contributing
============

Bugs in the content should be reported to the Python bug tracker at
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

"Bugs in the content should be reported to the [Python bug tracker]."

used to build the docs. It is not included in this tree, but maintained
separately and available from PyPI <https://pypi.python.org/pypi/Sphinx>.
separately and available from`PyPI <https://pypi.python.org/pypi/Sphinx>`_.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

and [available from PyPI].

@@ -3,19 +3,19 @@ Python Documentation README

This directory contains the reStructuredText (reST) sources to the Python
documentation. You don't need to build them yourself, prebuilt versions are
available at <https://docs.python.org/dev/download.html>.
available at`docs.python.org/dev/download.html<https://docs.python.org/dev/download.html>`_.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

..., [prebuilt versions are available].

@ghost
Copy link
Author

ghost commentedFeb 13, 2017•
edited by ghost
Loading

The reason the CLA bot is not showing me as signed is probably because I used the online editor for the original commit (which commits under the noreply@github address). My email address isnarayan<>roger<>@<>gmail.com (remove the <>)

@codecov
Copy link

codecovbot commentedFeb 13, 2017

Codecov Report

Merging#19 intomaster willdecrease coverage by-0.01%.
The diff coverage isn/a.

@@            Coverage Diff             @@##           master      #19      +/-   ##==========================================- Coverage   82.37%   82.37%   -0.01%==========================================  Files        1427     1427                Lines      350948   350948              ==========================================- Hits       289091   289089       -2- Misses      61857    61859       +2

Continue to review full report at Codecov.

Legend -Click here to learn more
Δ = absolute <relative> (impact),ø = not affected,? = missing data
Powered byCodecov. Last update29896ad...08cb2a3. Read thecomment docs.

@ghost
Copy link
Author

@Haypo The changes you requested were made

@ghost
Copy link
Author

It is still not showing up on my account! I have filed a new one for each day it has not been added.

@berkerpeksag
Copy link
Member

Please note that the PSF is based in the United States and they can only process CLA requests in workdays.

@ghost
Copy link
Author

I am moving this PR soon now that my CLA is confirmed and due to overlaps with the master branch.

@ghostghost closed thisFeb 15, 2017
@ghost
Copy link
Author

Moved to#104 and my CLA is now processed

paulmon added a commit to paulmon/cpython that referenced this pull requestJan 10, 2019
nanjekyejoannah added a commit to nanjekyejoannah/cpython that referenced this pull requestFeb 1, 2023
19: Warn for range and xrange r=ltratt a=nanjekyejoannahSee notes:```Py2.x:>>> x = xrange(1, 10000)>>> a = range(1,10000)>>> type(a)<type 'list'>>>> Py3.x:>>> x = xrange(1, 10000)Traceback (most recent call last):  File "<stdin>", line 1, in <module>NameError: name 'xrange' is not defined>>> a = range(1,10000)>>> type(a)<class 'range'>>>> ```Co-authored-by: Joannah Nanjekye <jnanjekye@python.org>
oraluben pushed a commit to oraluben/cpython that referenced this pull requestJun 25, 2023
* fix: off by one error in forward jump calculation* Test: fixed test forpython#18* test: remove broken test---------Co-authored-by: Jules <julia.poo.poo.poo@gmail.com>
This pull request wasclosed.
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

7 participants
@the-knights-who-say-ni@methane@orsenthil@vstinner@berkerpeksag@zware@Mariatta
[8]ページ先頭
©2009-2025 Movatter.jp