Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork33.3k
bpo-39850: Add support for abstract sockets in multiprocessing#18866
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Uh oh!
There was an error while loading.Please reload this page.
Conversation
4c3361e to338696bCompare4fa7210 to95575e1Compare
pitrou left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
LGTM, just a nit.
Uh oh!
There was an error while loading.Please reload this page.
pitrou commentedMar 9, 2020
By the way, I don't think this can be backported since it's a behaviour change. If we want to fix support for abstract sockets on 3.7-3.8 we'll need a different patch. |
Uh oh!
There was an error while loading.Please reload this page.
Uh oh!
There was an error while loading.Please reload this page.
Uh oh!
There was an error while loading.Please reload this page.
pablogsal commentedMar 9, 2020
@pitrou Would you like me to split this PR in two (one with the fix 'per se' and the other with the new default)? Another possibility is that I create manually the backports, removing the new behaviour in the process. |
Uh oh!
There was an error while loading.Please reload this page.
Uh oh!
There was an error while loading.Please reload this page.
pitrou commentedMar 9, 2020
@pablogsal As is the most convenient for you. |
Co-Authored-By: Victor Stinner <vstinner@python.org>
Co-Authored-By: Victor Stinner <vstinner@python.org>
Uh oh!
There was an error while loading.Please reload this page.
Uh oh!
There was an error while loading.Please reload this page.
Uh oh!
There was an error while loading.Please reload this page.
pablogsal commentedMar 9, 2020
Always happy to do them! Thanks for the review :) |
…ythonGH-18866)(cherry picked from commit6012f30)Co-authored-by: Pablo Galindo <Pablogsal@gmail.com>
…ssing (pythonGH-18866)(cherry picked from commit6012f30)Co-authored-by: Pablo Galindo <Pablogsal@gmail.com>.(cherry picked from commit5e217bb)Co-authored-by: Pablo Galindo <Pablogsal@gmail.com>
AmirHmZz commentedApr 3, 2020
So now does windows support |
Linux abstract sockets are insecure as they lack any form of filesystempermissions so their use allows anyone on the system to inject code intothe process.This removes the default preference for abstract sockets inmultiprocessing introduced in Python 3.9+ via#18866 while fixing#84031.Explicit use of an abstract socket by a user now generates aRuntimeWarning. If we choose to keep this warning, it should bebackported to the 3.7 and 3.8 branches.
…ythonGH-98501)Linux abstract sockets are insecure as they lack any form of filesystempermissions so their use allows anyone on the system to inject code intothe process.This removes the default preference for abstract sockets inmultiprocessing introduced in Python 3.9+ viapython#18866 while fixingpython#84031.Explicit use of an abstract socket by a user now generates aRuntimeWarning. If we choose to keep this warning, it should bebackported to the 3.7 and 3.8 branches.(cherry picked from commit49f6106)Co-authored-by: Gregory P. Smith <greg@krypto.org>
…ythonGH-98501)Linux abstract sockets are insecure as they lack any form of filesystempermissions so their use allows anyone on the system to inject code intothe process.This removes the default preference for abstract sockets inmultiprocessing introduced in Python 3.9+ viapython#18866 while fixingpython#84031.Explicit use of an abstract socket by a user now generates aRuntimeWarning. If we choose to keep this warning, it should bebackported to the 3.7 and 3.8 branches.(cherry picked from commit49f6106)Co-authored-by: Gregory P. Smith <greg@krypto.org>
…ythonGH-98501)Linux abstract sockets are insecure as they lack any form of filesystempermissions so their use allows anyone on the system to inject code intothe process.This removes the default preference for abstract sockets inmultiprocessing introduced in Python 3.9+ viapython#18866 while fixingpython#84031.Explicit use of an abstract socket by a user now generates aRuntimeWarning. If we choose to keep this warning, it should bebackported to the 3.7 and 3.8 branches.(cherry picked from commit49f6106)Co-authored-by: Gregory P. Smith <greg@krypto.org>
…ythonGH-98501)Linux abstract sockets are insecure as they lack any form of filesystempermissions so their use allows anyone on the system to inject code intothe process.This removes the default preference for abstract sockets inmultiprocessing introduced in Python 3.9+ viapython#18866 while fixingpython#84031.Explicit use of an abstract socket by a user now generates aRuntimeWarning. If we choose to keep this warning, it should bebackported to the 3.7 and 3.8 branches.(cherry picked from commit49f6106)Co-authored-by: Gregory P. Smith <greg@krypto.org>
…GH-98501) (GH-98503)Linux abstract sockets are insecure as they lack any form of filesystempermissions so their use allows anyone on the system to inject code intothe process.This removes the default preference for abstract sockets inmultiprocessing introduced in Python 3.9+ via#18866 while fixing#84031.Explicit use of an abstract socket by a user now generates aRuntimeWarning. If we choose to keep this warning, it should bebackported to the 3.7 and 3.8 branches.(cherry picked from commit49f6106)Co-authored-by: Gregory P. Smith <greg@krypto.org>Automerge-Triggered-By: GH:gpshead
…GH-98501) (GH-98502)Linux abstract sockets are insecure as they lack any form of filesystempermissions so their use allows anyone on the system to inject code intothe process.This removes the default preference for abstract sockets inmultiprocessing introduced in Python 3.9+ via#18866 while fixing#84031.Explicit use of an abstract socket by a user now generates aRuntimeWarning. If we choose to keep this warning, it should bebackported to the 3.7 and 3.8 branches.(cherry picked from commit49f6106)Co-authored-by: Gregory P. Smith <greg@krypto.org>Automerge-Triggered-By: GH:gpshead
…GH-98501) (GH-98502)Linux abstract sockets are insecure as they lack any form of filesystempermissions so their use allows anyone on the system to inject code intothe process.This removes the default preference for abstract sockets inmultiprocessing introduced in Python 3.9+ via#18866 while fixing#84031.Explicit use of an abstract socket by a user now generates aRuntimeWarning. If we choose to keep this warning, it should bebackported to the 3.7 and 3.8 branches.(cherry picked from commit49f6106)Co-authored-by: Gregory P. Smith <greg@krypto.org>Automerge-Triggered-By: GH:gpshead
…H-98501) (#98504)Linux abstract sockets are insecure as they lack any form of filesystempermissions so their use allows anyone on the system to inject code intothe process.This removes the default preference for abstract sockets inmultiprocessing introduced in Python 3.9+ via#18866 while fixing#84031.Explicit use of an abstract socket by a user now generates aRuntimeWarning. If we choose to keep this warning, it should bebackported to the 3.7 and 3.8 branches.(cherry picked from commit49f6106)Co-authored-by: Gregory P. Smith <greg@krypto.org>
Linux abstract sockets are insecure as they lack any form of filesystempermissions so their use allows anyone on the system to inject code intothe process.This removes the default preference for abstract sockets inmultiprocessing introduced in Python 3.9+ viapython#18866 while fixingpython#84031.Explicit use of an abstract socket by a user now generates aRuntimeWarning. If we choose to keep this warning, it should bebackported to the 3.7 and 3.8 branches.(cherry picked from commit49f6106)Co-authored-by: Gregory P. Smith <greg@krypto.org>Automerge-Triggered-By: GH:gpshead
Uh oh!
There was an error while loading.Please reload this page.
https://bugs.python.org/issue39850