NotificationsYou must be signed in to change notification settings
Fork33.3k
Star69.7k

gh-76785: Multiple Interpreters in the Stdlib (PEP 554)#18817

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Jump to bottom

Closed

nanjekyejoannah wants to merge21 commits intopython:mainfromnanjekyejoannah:PEP_554_high_level

Closed

gh-76785: Multiple Interpreters in the Stdlib (PEP 554)#18817

nanjekyejoannah wants to merge21 commits intopython:mainfromnanjekyejoannah:PEP_554_high_level

Conversation

Copy link

Contributor

nanjekyejoannah commentedMar 6, 2020•
edited by bedevere-appbot
Loading

This is the initial implementation of the high-level part of PEP 554.

I have added some changes from#17323 by@LewisGaul to aid have the ability to List interpreters associated with a channel end.

Co-author : Lewis Gaul.

cc@ericsnowcurrently @vstinner

https://bugs.python.org/issue39881

Issue:[subinterpreters] PEP 554 implementation: add interpreters module #76785

nanjekyejoannahand others added17 commits

September 10, 2019 11:00

Add tests for the interpreters module

f5b464a

create stdlib interpreters module and _interpreters internal module

331be62

Global initial Sub-Interpreters functions

3f2f2f4

update __all__

4618343

Implementation of all methods and relevant documentation

ec63183

Update Lib/test/test_interpreters.py

80f6808

Co-Authored-By: Eric Snow <ericsnowcurrently@gmail.com>

Update Lib/test/test_interpreters.py

724e618

Co-Authored-By: Eric Snow <ericsnowcurrently@gmail.com>

Update Lib/test/test_interpreters.py

abd0011

Co-Authored-By: Eric Snow <ericsnowcurrently@gmail.com>

Update Lib/test/test_interpreters.py

d502415

Co-Authored-By: Eric Snow <ericsnowcurrently@gmail.com>

Update Doc/library/interpreters.rst

a751e15

Co-Authored-By: Eric Snow <ericsnowcurrently@gmail.com>

Update Doc/library/interpreters.rst

56083c2

Co-Authored-By: Eric Snow <ericsnowcurrently@gmail.com>

Update Doc/library/interpreters.rst

14e97fc

Co-Authored-By: Eric Snow <ericsnowcurrently@gmail.com>

Add tests

9ab54eb

Fix tests

b7dce73

Add send buffer functionality

e9b56b8

Add tests for Global functions and Interpreter

2bf89d4

Test coverage and documentation

158e54f

nanjekyejoannah requested a review fromericsnowcurrently

March 6, 2020 22:06

nanjekyejoannah requested a review froma team as acode owner

March 6, 2020 22:06

the-knights-who-say-ni added the CLA signed label

Mar 6, 2020

bedevere-bot added the awaiting core review label

Mar 6, 2020

blurb-itbotand others added2 commits

March 6, 2020 22:09

📜🤖 Added by blurb_it.

9e2f9d6

Fix Merge conflict

2e608fb

aeros reviewed

Mar 8, 2020

View reviewed changes

Copy link

Contributor

aeros left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Thanks for working on this@nanjekyejoannah! As someone who hasn't extensively worked with subinterpreters (mainly since it was only available through the C-API), I greatly look forward to exploring their various use cases and experimenting with them as model of concurrency. :)

I have some general suggestions regarding the documentation; I'll try to add some additional ones as I find the time.

Doc/library/interpreters.rst OutdatedShow resolvedHide resolved

Doc/library/interpreters.rst

Comment on lines +25 to +28

		.. method:: is_running()

		Return whether or not the identified interpreter is running.
		It returns `True` and `False` otherwise.

Copy link

Contributor

aerosMar 8, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

IMO, this could be better phrased as:

Return `True` if the identified interpreter is running.

For comparison, seehttps://docs.python.org/3/library/asyncio-eventloop.html#asyncio.loop.is_running orhttps://docs.python.org/3/library/concurrent.futures.html#concurrent.futures.Future.cancelled.

Doc/library/interpreters.rst

Comment on lines +30 to +33

		.. method:: destroy()

		Destroy the interpreter. Attempting to destroy the current
		interpreter results in a `RuntimeError`.

Copy link

Contributor

aerosMar 8, 2020•
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

IIRC, it also results in aRuntimeError if an interpreter is attempted to be destroyed which is presently running (from my recollection of the C-API function,interp_destroy()). Could this also be mentioned?

Doc/library/interpreters.rst

Comment on lines +61 to +65

		.. method:: release()

		Release the channel for the current interpreter.
		By default both ends are released. Releasing an already
		released end results in a ``ChannelReleasedError`` exception.

Copy link

Contributor

aerosMar 8, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

IMO, the second sentence could be better phrased as:

Releasing an end more than once results in a:exc:`ChannelReleasedError`.

(Also added a Sphinx role, which should generate an inline link to the exception definition below)

Doc/library/interpreters.rst

Comment on lines +100 to +102

		.. method:: send_buffer_nowait(obj)

		Like ``send_buffer()`` but return ``False`` if not received.

Copy link

Contributor

aerosMar 8, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

See my above comment onsend_nowait().

Doc/library/interpreters.rstShow resolvedHide resolved

Doc/library/interpreters.rst


		Close the channel in all interpreters. By default
		both ends are closed. closing an already closed end
		results in a ``ChannelClosedError`` exception.

Copy link

Contributor

aerosMar 8, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Suggested change

	results in a``ChannelClosedError`` exception.
	results in a:exc:`ChannelClosedError`.

Doc/library/interpreters.rst

Comment on lines +129 to +131

		.. function:: list_all_channels()

		Return all open channels.

Copy link

Contributor

aerosMar 8, 2020•
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Does this return a list of Channel objects or something else? I think it would be helpful to mention that here.

Doc/library/interpreters.rst

Comment on lines +133 to +136

		.. function:: create()

		Initialize a new (idle) Python interpreter. Get the currently
		running interpreter. This method returns an ``Interpreter`` object.

Copy link

Contributor

aerosMar 8, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Was "Get the currently running interpreter" accidentally included here?

aeros added the type-featureA feature request or enhancement label

Mar 8, 2020

nanjekyejoannah mentioned this pull request

Apr 25, 2020

bpo-38880: List interpreters associated with a channel end#17323

Merged

nanjekyejoannahand others added2 commits

May 7, 2020 18:01

Update Doc/library/interpreters.rst

71ad4d7

Co-authored-by: Kyle Stanley <aeros167@gmail.com>

Update Doc/library/interpreters.rst

b12e3d2

Co-authored-by: Kyle Stanley <aeros167@gmail.com>

vstinner changed the title~~bpo-39881: Multiple Interpreters in the Stdlib (PEP 554)~~bpo-32604: Multiple Interpreters in the Stdlib (PEP 554)

May 15, 2020

Copy link

Member

vstinner commentedMay 15, 2020•
edited by bedevere-bot
Loading

I markedbpo-39881 as a duplicate ofbpo-32604. I changed this PR title to usebpo-32604.

ericsnowcurrently mentioned this pull request

Apr 10, 2022

[subinterpreters] PEP 554 implementation: add interpreters module#76785

Closed

ezio-melotti removed the CLA signed label

Jul 13, 2022

erlend-aasland changed the title~~bpo-32604: Multiple Interpreters in the Stdlib (PEP 554)~~gh-76785: Multiple Interpreters in the Stdlib (PEP 554)

Jan 12, 2024

Copy link

Contributor

erlend-aasland commentedJan 12, 2024

This PR should be retargeted toPEP-734.

Copy link

python-cla-botbot commentedApr 18, 2025

The following commit authors need to sign the Contributor License Agreement:

33177550+nanjekyejoannah@users.noreply.github.com

Copy link

Member

StanFromIreland commentedAug 20, 2025

Completed in:#133958

StanFromIreland closed this

Aug 20, 2025

Labels

awaiting core review type-feature

A feature request or enhancement

Movatterモバイル変換

Uh oh!

gh-76785: Multiple Interpreters in the Stdlib (PEP 554)#18817

gh-76785: Multiple Interpreters in the Stdlib (PEP 554)#18817

Uh oh!

Conversation

nanjekyejoannah commentedMar 6, 2020• edited by bedevere-appbotLoading Uh oh!There was an error while loading.Please reload this page.

Uh oh!

Uh oh!

aeros left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

aerosMar 8, 2020

Choose a reason for hiding this comment

Uh oh!

aerosMar 8, 2020• editedLoading Uh oh!There was an error while loading.Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

aerosMar 8, 2020

Choose a reason for hiding this comment

Uh oh!

aerosMar 8, 2020

Choose a reason for hiding this comment

Uh oh!

Uh oh!

aerosMar 8, 2020

Choose a reason for hiding this comment

Uh oh!

aerosMar 8, 2020• editedLoading Uh oh!There was an error while loading.Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

aerosMar 8, 2020

Choose a reason for hiding this comment

Uh oh!

vstinner commentedMay 15, 2020• edited by bedevere-botLoading Uh oh!There was an error while loading.Please reload this page.

Uh oh!

Uh oh!

erlend-aasland commentedJan 12, 2024

Uh oh!

python-cla-botbot commentedApr 18, 2025

Uh oh!

StanFromIreland commentedAug 20, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

8 participants

nanjekyejoannah commentedMar 6, 2020•
edited by bedevere-appbot
Loading

aerosMar 8, 2020•
edited
Loading

aerosMar 8, 2020•
edited
Loading

vstinner commentedMay 15, 2020•
edited by bedevere-bot
Loading