Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

bpo-30514: test_pop3lib asyncore with asyncio#1864

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Open
grzgrzgrz3 wants to merge2 commits intopython:main
base:main
Choose a base branch
Loading
fromgrzgrzgrz3:bpo30514-grzegorz-grzywacz-poplib

Conversation

@grzgrzgrz3
Copy link
Contributor

@grzgrzgrz3grzgrzgrz3 commentedMay 30, 2017•
edited by JelleZijlstra
Loading

Pop3 server stub was base on asyncore/asynchat which is deprecated, new
stub is using asyncio instead.

test_too_long_lines make sure we read remaining overlong response

cmd_user answer only with +ERR message on invalid user

#74699

Pop3 server stub was base on asyncore/asynchat which is deprecated, newstub is using asyncio instead.test_too_long_lines make sure we read remaining overlong responsecmd_user answer only with +ERR message on invalid user
@mention-bot
Copy link

@grzgrzgrz3, thanks for your PR! By analyzing the history of the files in this pull request, we identified@tiran,@serhiy-storchaka and@giampaolo to be potential reviewers.

@codecov
Copy link

codecovbot commentedMay 30, 2017

Codecov Report

❗ No coverage uploaded for pull request base (master@9c972b5).Click here to learn what that means.
The diff coverage is97.67%.

Impacted file tree graph

@@            Coverage Diff            @@##             master    #1864   +/-   ##=========================================  Coverage          ?   82.68%           =========================================  Files             ?     1432             Lines             ?   353405             Branches          ?        0           =========================================  Hits              ?   292229             Misses            ?    61176             Partials          ?        0
Impacted FilesCoverage Δ
Lib/test/test_poplib.py98.13% <97.67%> (ø)

Continue to review full report at Codecov.

Legend -Click here to learn more
Δ = absolute <relative> (impact),ø = not affected,? = missing data
Powered byCodecov. Last update9c972b5...996e0cc. Read thecomment docs.

@serhiy-storchakaserhiy-storchaka added the testsTests in the Lib/test dir labelDec 8, 2018
@matrixisematrixise self-assigned thisSep 12, 2019
Copy link

@auvipyauvipy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

a rebase on top of main branch would be a good first start

@github-actions
Copy link

This PR is stale because it has been open for 30 days with no activity.

@github-actionsgithub-actionsbot added the staleStale PR or inactive for long period of time. labelFeb 19, 2022
@grzgrzgrz3grzgrzgrz3mannequin mentioned this pull requestApr 11, 2022
@JelleZijlstraJelleZijlstra self-assigned thisMay 10, 2022
@JelleZijlstra
Copy link
Member

I'll work on getting this up to date so it unblocks removing asyncore. Note to self: local branch name isbpo30514-grzegorz-grzywacz-poplib.

@github-actionsgithub-actionsbot removed the staleStale PR or inactive for long period of time. labelMay 11, 2022
@AA-Turner
Copy link
Member

Triggering CLA.

@github-actions
Copy link

This PR is stale because it has been open for 30 days with no activity.

@github-actionsgithub-actionsbot added the staleStale PR or inactive for long period of time. labelJul 8, 2022
@github-actionsgithub-actionsbot removed the staleStale PR or inactive for long period of time. labelOct 10, 2022
@github-actions
Copy link

This PR is stale because it has been open for 30 days with no activity.

@github-actionsgithub-actionsbot added the staleStale PR or inactive for long period of time. labelNov 10, 2022
@JelleZijlstraJelleZijlstra removed their assignmentNov 12, 2022
@github-actionsgithub-actionsbot removed the staleStale PR or inactive for long period of time. labelNov 13, 2022
@github-actions
Copy link

This PR is stale because it has been open for 30 days with no activity.

@github-actionsgithub-actionsbot added the staleStale PR or inactive for long period of time. labelDec 14, 2022
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

1 more reviewer

@auvipyauvipyauvipy requested changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

awaiting core reviewstaleStale PR or inactive for long period of time.testsTests in the Lib/test dir

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

13 participants

@grzgrzgrz3@mention-bot@JelleZijlstra@AA-Turner@auvipy@matrixise@brettcannon@serhiy-storchaka@Mariatta@the-knights-who-say-ni@bedevere-bot@kumaraditya303@AlexWaygood
[8]ページ先頭
©2009-2025 Movatter.jp