Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork32.1k
gh-64383: Migrate builtins.vars and builtins.dir to Argument Clinic#18512
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Uh oh!
There was an error while loading.Please reload this page.
Conversation
Codecov Report
@@ Coverage Diff @@## master #18512 +/- ##===========================================+ Coverage 79.46% 83.20% +3.73%=========================================== Files 384 1571 +1187 Lines 169290 414730 +245440 Branches 0 44456 +44456 ===========================================+ Hits 134529 345067 +210538- Misses 34761 60020 +25259- Partials 0 9643 +9643 Continue to review full report at Codecov.
|
Sorry this had to wait for so long! If you're still interested, would you be able to fix the merge conflicts? Then I can review it and get it merged. |
Oh, Thanks. Give me some time to take a look. I forget the details already :( |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Requesting changes for fixing the conflicts, as per above
bedevere-bot commentedFeb 9, 2023
A Python core developer has requested some changes be made to your pull request before we can consider merging it. If you could please address their requests along with any other requests in other reviews from core developers that would be appreciated. Once you have made the requested changes, please leave a comment on this pull request containing the phrase |
Superseded bygh-100358. |
Uh oh!
There was an error while loading.Please reload this page.
https://bugs.python.org/issue20184