Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

gh-64383: Migrate builtins.vars and builtins.dir to Argument Clinic#18512

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Closed
shihai1991 wants to merge2 commits intopython:mainfromshihai1991:bpo_20184

Conversation

shihai1991
Copy link
Member

@shihai1991shihai1991 commentedFeb 15, 2020
edited by bedevere-bot
Loading

@codecov
Copy link

codecovbot commentedFeb 15, 2020

Codecov Report

Merging#18512 intomaster willincrease coverage by3.73%.
The diff coverage isn/a.

Impacted file tree graph

@@             Coverage Diff             @@##           master   #18512       +/-   ##===========================================+ Coverage   79.46%   83.20%    +3.73%===========================================  Files         384     1571     +1187       Lines      169290   414730   +245440       Branches        0    44456    +44456     ===========================================+ Hits       134529   345067   +210538- Misses      34761    60020    +25259- Partials        0     9643     +9643
Impacted FilesCoverage Δ
Python/dynload_shlib.c
Parser/parsetok.c
Python/marshal.c
Python/hamt.c
Python/clinic/sysmodule.c.h
Objects/bytes_methods.c
Modules/_hashopenssl.c
Modules/_ctypes/callbacks.c
Modules/cjkcodecs/cjkcodecs.h
Objects/capsule.c
... and1943 more

Continue to review full report at Codecov.

Legend -Click here to learn more
Δ = absolute <relative> (impact),ø = not affected,? = missing data
Powered byCodecov. Last updatef632736...3b315ef. Read thecomment docs.

@JelleZijlstra
Copy link
Member

Sorry this had to wait for so long! If you're still interested, would you be able to fix the merge conflicts? Then I can review it and get it merged.

@shihai1991
Copy link
MemberAuthor

Sorry this had to wait for so long! If you're still interested, would you be able to fix the merge conflicts? Then I can review it and get it merged.

Oh, Thanks. Give me some time to take a look. I forget the details already :(

Copy link
Contributor

@hauntsaninjahauntsaninja left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Requesting changes for fixing the conflicts, as per above

@bedevere-bot
Copy link

A Python core developer has requested some changes be made to your pull request before we can consider merging it. If you could please address their requests along with any other requests in other reviews from core developers that would be appreciated.

Once you have made the requested changes, please leave a comment on this pull request containing the phraseI have made the requested changes; please review again. I will then notify any core developers who have left a review that you're ready for them to take another look at this pull request.

@arhadthedevarhadthedev changed the titlebpo-20184: Migrate builtins.vars and builtins.dir to Argument Clinicgh-64383: Migrate builtins.vars and builtins.dir to Argument ClinicFeb 13, 2023
@arhadthedevarhadthedev added the interpreter-core(Objects, Python, Grammar, and Parser dirs) labelFeb 13, 2023
@arhadthedev
Copy link
Member

Superseded bygh-100358.

Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Reviewers

@hauntsaninjahauntsaninjahauntsaninja requested changes

@ncoghlanncoghlanAwaiting requested review from ncoghlan

@larryhastingslarryhastingsAwaiting requested review from larryhastings

Assignees
No one assigned
Labels
awaiting changesinterpreter-core(Objects, Python, Grammar, and Parser dirs)topic-argument-clinic
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

8 participants
@shihai1991@JelleZijlstra@bedevere-bot@arhadthedev@hauntsaninja@serhiy-storchaka@the-knights-who-say-ni@ezio-melotti

[8]ページ先頭

©2009-2025 Movatter.jp