Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

Rename Doc/README.txt to Doc/README.rst#18

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Closed
ghost wants to merge7 commits intopython:masterfromunknown repository
Closed

Rename Doc/README.txt to Doc/README.rst#18

ghost wants to merge7 commits intopython:masterfromunknown repository

Conversation

ghost
Copy link

@ghostghost commentedFeb 11, 2017
edited by ghost
Loading

I have simply updated the document and its references to README.rst (thanks to whoever formatted it).

@the-knights-who-say-ni

Hello, and thanks for your contribution!

I'm a bot set up to make sure that the project can legally accept your contribution by verifying you have signed thePSF contributor agreement (CLA).

Unfortunately our records indicate you have not signed the CLA. For legal reasons we need you to sign this before we can look at your contribution. Please follow these steps to rectify the issue:

  1. Sign thePSF contributor agreement
  2. Wait at least a day and then check "Your Details" onbugs.python.org to see if your account has been marked as having signed the CLA (the delay is due to a person having to manually check your signed CLA)
  3. Reply here saying you have completed the above steps

Thanks again to your contribution and we look forward to looking at it!

@ghostghost changed the titleRename README.txt to README.rstRename Doc/README.txt to Doc/README.rstFeb 11, 2017
@ghost
Copy link
Author

I have signed the CLA, so the PR will take a day for approval

@methane
Copy link
Member

@rogersachan master branch already renamed README.txt -> README.rst
Please rebase your branch.

@ghost
Copy link
Author

I accidentally merged and destroyed this PR, so I'll close it now.

P.S. The extra option next to the merge button would have let you rebase it but ¯_(ツ)_/¯

@ghostghost closed thisFeb 11, 2017
@willingc
Copy link
Contributor

Hi @rogersachan,

Thanks for the PR. It's common practice in open source for the contributor to rebase their submission instead of the maintainer doing it. By the contributor doing the rebase, it makes things more efficient for multiple reviewers. 👍

paulmon added a commit to paulmon/cpython that referenced this pull requestJan 10, 2019
nanjekyejoannah added a commit to nanjekyejoannah/cpython that referenced this pull requestFeb 1, 2023
18: Warn for encode and decode in base64 r=ltratt a=nanjekyejoannahAdd warnings for the base module.**Notes:**```py2.x>>> import base64>>> from base64 import decodestring>>> py3.x:>>> import base64>>> from base64 import decodestringTraceback (most recent call last):  File "<stdin>", line 1, in <module>ImportError: cannot import name 'decodestring' from 'base64' (/usr/local/Cellar/python@3.9/3.9.12_1/Frameworks/Python.framework/Versions/3.9/lib/python3.9/base64.py)```Co-authored-by: Joannah Nanjekye <jnanjekye@python.org>
oraluben pushed a commit to oraluben/cpython that referenced this pull requestJun 25, 2023
* fix: off by one error in forward jump calculation* Test: fixed test forpython#18* test: remove broken test---------Co-authored-by: Jules <julia.poo.poo.poo@gmail.com>
This pull request wasclosed.
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

4 participants
@the-knights-who-say-ni@methane@willingc@superusercode

[8]ページ先頭

©2009-2025 Movatter.jp