Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork32k
gh-72353: WindowsConsoleIO misbehavior when Ctrl+C is ignored#17976
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
base:main
Are you sure you want to change the base?
gh-72353: WindowsConsoleIO misbehavior when Ctrl+C is ignored#17976
Uh oh!
There was an error while loading.Please reload this page.
Conversation
Continue to read if SIGINT is ignored or the handler doesn't raisean exception.Co-Authored-By: Valeriya Sinevich <valeriya.sinevich@phystech.edu>
| if (WaitForSingleObjectEx(hInterruptEvent, 100, FALSE) | ||
| ==WAIT_OBJECT_0) { | ||
| DWORD state =WaitForSingleObjectEx(hInterruptEvent, 100, FALSE); | ||
| if (state == WAIT_OBJECT_0 || state==WAIT_TIMEOUT) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Considering every other possible result is a hard error (which we're currently ignoring... whoops), I don't think this is the right condition.
Probably in theWAIT_TIMEOUT case we want to justcontinue and not callPyErr_CheckSignals? We certainly shouldn't reset the event, because we haven't been given it
Uh oh!
There was an error while loading.Please reload this page.
Continue to read if SIGINT is ignored or the handler doesn't raise
an exception.
Co-Authored-By: Valeriya Sinevichvaleriya.sinevich@phystech.edu
https://bugs.python.org/issue28166