Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork33.3k
Add .idea and .iml to .gitignore#1764
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Uh oh!
There was an error while loading.Please reload this page.
Conversation
mention-bot commentedMay 23, 2017
the-knights-who-say-ni commentedMay 23, 2017
Hello, and thanks for your contribution! I'm a bot set up to make sure that the project can legally accept your contribution by verifying you have signed thePSF contributor agreement (CLA). Unfortunately our records indicate you have not signed the CLA. For legal reasons we need you to sign this before we can look at your contribution. Please followthe steps outlined in the CPython devguide to rectify this issue. Thanks again to your contribution and we look forward to looking at it! |
gfyoung commentedMay 23, 2017 • edited
Loading Uh oh!
There was an error while loading.Please reload this page.
edited
Uh oh!
There was an error while loading.Please reload this page.
I signed the CLA two days ago. How long does it take to propagate? Or should I forward the confirmation email to somebody? |
zooba commentedMay 24, 2017
Thanks! |
berkerpeksag commentedMay 24, 2017
gfyoung commentedMay 24, 2017 • edited
Loading Uh oh!
There was an error while loading.Please reload this page.
edited
Uh oh!
There was an error while loading.Please reload this page.
Fair enough, though I think this comment at the end of the PRhere suggests that perhaps that that suggestion should be reconsidered. I see no reason to assume that users have a global |
berkerpeksag commentedMay 24, 2017
Using a global .gitignore file is a best practice. That last comment was about syncing .gitignore with .hgignore. |
gfyoung commentedMay 24, 2017
Best practice but not required. Call me cynical, but I don't expect users to do this (in my case, I was working on a machine other than my own and accidentally committed these changes in another PR). |
These arose when working with the repository in IntelliJ IDE. This is a trivial PR.