Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

Add .idea and .iml to .gitignore#1764

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
zooba merged 1 commit intopython:masterfromgfyoung:gitignore-add
May 24, 2017
Merged

Add .idea and .iml to .gitignore#1764

zooba merged 1 commit intopython:masterfromgfyoung:gitignore-add
May 24, 2017

Conversation

@gfyoung
Copy link
Contributor

These arose when working with the repository in IntelliJ IDE. This is a trivial PR.

@mention-bot
Copy link

@gfyoung, thanks for your PR! By analyzing the history of the files in this pull request, we identified@akheron,@zware and@zooba to be potential reviewers.

@the-knights-who-say-ni

Hello, and thanks for your contribution!

I'm a bot set up to make sure that the project can legally accept your contribution by verifying you have signed thePSF contributor agreement (CLA).

Unfortunately our records indicate you have not signed the CLA. For legal reasons we need you to sign this before we can look at your contribution. Please followthe steps outlined in the CPython devguide to rectify this issue.

Thanks again to your contribution and we look forward to looking at it!

@gfyoung
Copy link
ContributorAuthor

gfyoung commentedMay 23, 2017
edited
Loading

Unfortunately our records indicate you have not signed the CLA.

I signed the CLA two days ago. How long does it take to propagate? Or should I forward the confirmation email to somebody?

@zoobazooba merged commitc0fa4ba intopython:masterMay 24, 2017
@zooba
Copy link
Member

Thanks!

gfyoung reacted with thumbs up emoji

@gfyounggfyoung deleted the gitignore-add branchMay 24, 2017 16:34
@berkerpeksag
Copy link
Member

Note that a nearly identical PR (see#6) was rejected before because users can use a global .gitignore file (see alsobpo-29510 for Eclipse.)

@gfyoung
Copy link
ContributorAuthor

gfyoung commentedMay 24, 2017
edited
Loading

Fair enough, though I think this comment at the end of the PRhere suggests that perhaps that that suggestion should be reconsidered. I see no reason to assume that users have a global.gitignore file configured. That's seem to be just asking for accidental file commits.

@berkerpeksag
Copy link
Member

Using a global .gitignore file is a best practice. That last comment was about syncing .gitignore with .hgignore.

@gfyoung
Copy link
ContributorAuthor

Best practice but not required. Call me cynical, but I don't expect users to do this (in my case, I was working on a machine other than my own and accidentally committed these changes in another PR).

Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@gfyoung@mention-bot@the-knights-who-say-ni@zooba@berkerpeksag

[8]ページ先頭

©2009-2025 Movatter.jp