Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork32.1k
gh-83156: Add dedicated anchor for regexp syntax elements#17470
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
base:main
Are you sure you want to change the base?
Conversation
This comment was marked as resolved.
This comment was marked as resolved.
bd537bb
tod711127
CompareThere was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Thanks for your PR, and sorry it has been open for so long! I think these anchors are useful, but agree with@hugovk that it's hard to discover them with no |
Thanks for getting back to the PR eventually. I will look into how to add the pillcrow |
I added a new commit that turns all the headings into It does change the look of the page a little bit but I don't think it's for the worse personally. Here's the before/after on my machine: I also took the opportunity to add an |
Adding However, if we do want easily-clickable and copyable external links with the fragment id in the rendered document, section headings would need to be added. I'm not sure a way around them also being in the ToC without hacks or pushing them down 2+ heading levels, but maybe@AA-Turner knows a way? This hopefully won't be an issue in the future, though, as if we adopt a Sphinx theme like Lutra that separates the inter- and intra-document ToC into left and right sidebars, and for which we can limit the ToC depth of the latter to 2, we could avoid displaying them by only adding one layer of higher level sections (which seems quite appropriate to the current document content) and limiting page ToCs to displaying only up to h3 heading levels. |
Uh oh!
There was an error while loading.Please reload this page.