Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork33.4k
Adding missing acknowledgement#17130
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Merged
Merged
Uh oh!
There was an error while loading.Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
bpo-26467: large chunk of the "based on" codebpo-29302
brandtbucher approved these changesNov 12, 2019
Member
brandtbucher left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Thanks for your help!
Contributor
miss-islington commentedNov 13, 2019
Thanks@Kentzo for the PR, and@benjaminp for merging it 🌮🎉.. I'm working now to backport this PR to: 3.8. |
bedevere-bot commentedNov 13, 2019
GH-17138 is a backport of this pull request to the3.8 branch. |
miss-islington added a commit that referenced this pull requestNov 13, 2019
jacobneiltaylor pushed a commit to jacobneiltaylor/cpython that referenced this pull requestDec 5, 2019
Contributions on bpo-26467 and bpo-29302.
shihai1991 pushed a commit to shihai1991/cpython that referenced this pull requestJan 31, 2020
Contributions on bpo-26467 and bpo-29302.
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading.Please reload this page.
Due to:
[bpo-26467](#9296): large chunk of the "based on" Apache 2.0 licensed code
[bpo-29302](#4790)