NotificationsYou must be signed in to change notification settings
Fork32.2k
Star67.7k

Fix definition of multiple ']' in header#17086

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Jump to bottom

Closed

mark99i wants to merge2 commits intopython:masterfrommark99i:patch-1

Closed

Fix definition of multiple ']' in header#17086

mark99i wants to merge2 commits intopython:masterfrommark99i:patch-1

Conversation

Copy link

mark99i commentedNov 7, 2019•
edited
Loading

Fix definition of multiple ']' in header in configparser

in old version in example header is "[i love [python] lang]"
parse as "i love [python", only up to the first character ']'.

once fixed, multiple ']' can be used and this will not cause the header to be clipped.
now saving works correctly, but reading does not

fix definition of multiple ']' in header

46751c6

in old version in example header is "[i love [python] lang]"parse as "i love [python", only up to the first character ']'.once fixed, multiple ']' can be used and this will not cause the header to be clipped. now saving works correctly, but reading does not

the-knights-who-say-ni added the CLA not signed label

Nov 7, 2019

Copy link

the-knights-who-say-ni commentedNov 7, 2019

Hello, and thanks for your contribution!

I'm a bot set up to make sure that the project can legally accept this contribution by verifying everyone involved has signed thePSF contributor agreement (CLA).

Recognized GitHub username

We couldn't find abugs.python.org (b.p.o) account corresponding to the following GitHub usernames:

@mark99i

This might be simply due to a missing "GitHub Name" entry in one's b.p.o account settings. This is necessary for legal reasons before we can look at this contribution. Please followthe steps outlined in the CPython devguide to rectify this issue.

You cancheck yourself to see if the CLA has been received.

Thanks again for the contribution, we look forward to reviewing it!

bedevere-bot added the awaiting review label

Nov 7, 2019

📜🤖 Added by blurb_it.

3830cb7

brandtbucher requested changes

Nov 13, 2019

View reviewed changes

Copy link

Member

brandtbucher left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Sorry@mark99i, but I think this PR should be closed in favor of#17129, since it includes tests and doesn't break handling on the empty case.

Please make sure to include the "bpo-#####: " prefix in the PR title next time so that it properly links to the issue and others can see that you've begun work.