Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork32.4k
bpo-38449: Revert "bpo-22347: Update mimetypes.guess_type to allow oper parsing of URLs (GH-15522)"#16724
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Uh oh!
There was an error while loading.Please reload this page.
Conversation
…oper parsing of URLs (pythonGH-15522)"This reverts commit87bd207.
yarikoptic left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Could a unit test been added to verify (current and future) correct operation on a file name with; and may be other tricky symbols legit to be in a file name but not a URL?
maxking commentedOct 12, 2019 • edited by bedevere-bot
Loading Uh oh!
There was an error while loading.Please reload this page.
edited by bedevere-bot
Uh oh!
There was an error while loading.Please reload this page.
@yarikoptic This is just reverting the previous change which caused the regression so release managers can pick this up for the final releases. Fixes and more unit tests should be best added in the next PR which should fix the original issue and the issue raised inbpo-38449. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
LGTM, except it needs a news (blurb) entry about the revert since it introduces a change between 3.8.0rc1/3.7.5rc1 and 3.8.0final/3.7.5final.
bedevere-bot commentedOct 12, 2019
When you're done making the requested changes, leave the comment: |
I have made the requested changes; please review again |
bedevere-bot commentedOct 12, 2019
Thanks for making the requested changes! @ned-deily: please review the changes made to this pull request. |
Thanks@maxking for the PR 🌮🎉.. I'm working now to backport this PR to: 3.7, 3.8. |
Sorry@maxking, I had trouble checking out the |
bedevere-bot commentedOct 12, 2019
GH-16725 is a backport of this pull request to the3.7 branch. |
…er parsing of URLs (pythonGH-15522)" (pythonGH-16724)This reverts commit87bd207.https://bugs.python.org/issue38449(cherry picked from commit19a3d87)Co-authored-by: Abhilash Raj <maxking@users.noreply.github.com>
…low oper parsing of URLs (pythonGH-15522)" (pythonGH-16724)This reverts commit87bd207.https://bugs.python.org/issue38449(cherry picked from commit19a3d87)Co-authored-by: Abhilash Raj <maxking@users.noreply.github.com>
bedevere-bot commentedOct 12, 2019
GH-16728 is a backport of this pull request to the3.8 branch. |
…low oper parsing of URLs" (GH-16724) (GH-16728)This reverts commit87bd207.The reason for revert is a regression caused by the change in 3.8.0rc1, seebpo-38449 for more details.https://bugs.python.org/issue38449(cherry picked from commit19a3d87)Co-authored-by: Abhilash Raj <maxking@users.noreply.github.com>
…low oper parsing of URLs (GH-15685)" (GH-16724) (GH-16727)RevertsGH-15687 which caused the issue.https://bugs.python.org/issue22347https://bugs.python.org/issue38449
…low oper parsing of URLs (pythonGH-15685)" (pythonGH-16724) (pythonGH-16727)RevertspythonGH-15687 which caused the issue.https://bugs.python.org/issue22347https://bugs.python.org/issue38449
…er parsing of URLs (pythonGH-15522)" (pythonGH-16724)This reverts commit87bd207.https://bugs.python.org/issue38449
Uh oh!
There was an error while loading.Please reload this page.
This reverts commit87bd207.
https://bugs.python.org/issue38449
Automerge-Triggered-By:@maxking