Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork32.1k
bpo-37140: Fix StructUnionType_paramfunc()#15612
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Merged
Merged
Uh oh!
There was an error while loading.Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
Fix a ctypes regression of Python 3.8. When a ctypes.Structure ispassed by copy to a function, ctypes internals created a temporaryobject which had the side effect of calling the structure finalizer(__del__) twice. The Python semantics requires a finalizer to becalled exactly once. Fix ctypes internals to no longer call thefinalizer twice.Create a new internal StructParam_Type which is only used by_ctypes_callproc() to call PyMem_Free(ptr) on Py_DECREF(argument).StructUnionType_paramfunc() creates such object.
I wrote an unit test. I made sure that the unit test fails without the fix: Without the fix, Test.del() is called once internally during the call to the C function ("func()"), and then a second time when the object is destroyed (s = None). |
| (PyObject *)Py_TYPE(self), new_ptr); | ||
| copied_self->b_needsfree = 1; | ||
| obj = (&StructParam_Type)->tp_alloc(&StructParam_Type, 0); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
s/obj/arg_obj/ to increase readability ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
I chose "obj" name to get "parg->obj = obj" which looks nice to me :-)
Uh oh!
There was an error while loading.Please reload this page.
| s = None | ||
| support.gc_collect() | ||
| self.assertEqual(finalizer_calls, ["called"]) | ||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
<3 the test case
Thanks@vstinner for the PR 🌮🎉.. I'm working now to backport this PR to: 3.8. |
bedevere-bot commentedAug 30, 2019
GH-15613 is a backport of this pull request to the3.8 branch. |
miss-islington pushed a commit to miss-islington/cpython that referenced this pull requestAug 30, 2019
Fix a ctypes regression of Python 3.8. When a ctypes.Structure ispassed by copy to a function, ctypes internals created a temporaryobject which had the side effect of calling the structure finalizer(__del__) twice. The Python semantics requires a finalizer to becalled exactly once. Fix ctypes internals to no longer call thefinalizer twice.Create a new internal StructParam_Type which is only used by_ctypes_callproc() to call PyMem_Free(ptr) on Py_DECREF(argument).StructUnionType_paramfunc() creates such object.(cherry picked from commit96b4087)Co-authored-by: Victor Stinner <vstinner@redhat.com>
miss-islington added a commit that referenced this pull requestAug 30, 2019
Fix a ctypes regression of Python 3.8. When a ctypes.Structure ispassed by copy to a function, ctypes internals created a temporaryobject which had the side effect of calling the structure finalizer(__del__) twice. The Python semantics requires a finalizer to becalled exactly once. Fix ctypes internals to no longer call thefinalizer twice.Create a new internal StructParam_Type which is only used by_ctypes_callproc() to call PyMem_Free(ptr) on Py_DECREF(argument).StructUnionType_paramfunc() creates such object.(cherry picked from commit96b4087)Co-authored-by: Victor Stinner <vstinner@redhat.com>
lisroach pushed a commit to lisroach/cpython that referenced this pull requestSep 10, 2019
Fix a ctypes regression of Python 3.8. When a ctypes.Structure ispassed by copy to a function, ctypes internals created a temporaryobject which had the side effect of calling the structure finalizer(__del__) twice. The Python semantics requires a finalizer to becalled exactly once. Fix ctypes internals to no longer call thefinalizer twice.Create a new internal StructParam_Type which is only used by_ctypes_callproc() to call PyMem_Free(ptr) on Py_DECREF(argument).StructUnionType_paramfunc() creates such object.
DinoV pushed a commit to DinoV/cpython that referenced this pull requestJan 14, 2020
Fix a ctypes regression of Python 3.8. When a ctypes.Structure ispassed by copy to a function, ctypes internals created a temporaryobject which had the side effect of calling the structure finalizer(__del__) twice. The Python semantics requires a finalizer to becalled exactly once. Fix ctypes internals to no longer call thefinalizer twice.Create a new internal StructParam_Type which is only used by_ctypes_callproc() to call PyMem_Free(ptr) on Py_DECREF(argument).StructUnionType_paramfunc() creates such object.
websurfer5 pushed a commit to websurfer5/cpython that referenced this pull requestJul 20, 2020
Fix a ctypes regression of Python 3.8. When a ctypes.Structure ispassed by copy to a function, ctypes internals created a temporaryobject which had the side effect of calling the structure finalizer(__del__) twice. The Python semantics requires a finalizer to becalled exactly once. Fix ctypes internals to no longer call thefinalizer twice.Create a new internal StructParam_Type which is only used by_ctypes_callproc() to call PyMem_Free(ptr) on Py_DECREF(argument).StructUnionType_paramfunc() creates such object.
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Labels
None yet
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading.Please reload this page.
Fix a ctypes regression of Python 3.8. When a ctypes.Structure is
passed by copy to a function, ctypes internals created a temporary
object which had the side effect of calling the structure finalizer
(del) twice. The Python semantics requires a finalizer to be
called exactly once. Fix ctypes internals to no longer call the
finalizer twice.
Create a new internal StructParam_Type which is only used by
_ctypes_callproc() to call PyMem_Free(ptr) on Py_DECREF(argument).
StructUnionType_paramfunc() creates such object.
https://bugs.python.org/issue37140