Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

bpo-22347: Update mimetypes.guess_type to allow proper parsing of URLs#15522

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
miss-islington merged 2 commits intopython:masterfromcorona10:bpo-22347
Sep 5, 2019

Conversation

corona10
Copy link
Member

@corona10corona10 commentedAug 26, 2019•
edited by miss-islington
Loading

@corona10
Copy link
MemberAuthor

corona10 commentedAug 26, 2019•
edited
Loading

@zooba@asvetlov
This issue is pretty old remained an issue. I'd like to close this issue.
Can you please take a look?

@corona10corona10 changed the titlebpo-22347: Remove urllib.parse._splittype from mimetypes.guess_type.bpo-22347: Update mimetypes.guess_type to allow proper parsing of URLsAug 27, 2019
@corona10
Copy link
MemberAuthor

@epicfaace
Thanks for the review. I 've updated the PR. Please take a look

Copy link
Contributor

@epicfaaceepicfaace left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Looks good!

@corona10
Copy link
MemberAuthor

Thanks alot!

Copy link
Contributor

@maxkingmaxking left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Thanks@corona10 , The changes look good to me, except for the import statements (which I don't think needs any changes).

Please make sure to not force-pus after the changes and just add another additional commit. Merging the PR will squash the commits.

It is easier to lookup what changes were made after reviews through the additional commits and it gets lost if you force-push.

@bedevere-bot
Copy link

A Python core developer has requested some changes be made to your pull request before we can consider merging it. If you could please address their requests along with any other requests in other reviews from core developers that would be appreciated.

Once you have made the requested changes, please leave a comment on this pull request containing the phraseI have made the requested changes; please review again. I will then notify any core developers who have left a review that you're ready for them to take another look at this pull request.

@corona10
Copy link
MemberAuthor

@maxking
Thanks for the review, I will keep in mind not to use push force. :)
I've reverted the import.

@corona10corona10 requested a review frommaxkingAugust 31, 2019 20:51
@corona10
Copy link
MemberAuthor

I have made the requested changes; please review again

@bedevere-bot
Copy link

Thanks for making the requested changes!

@maxking: please review the changes made to this pull request.

Copy link
Contributor

@maxkingmaxking left a comment•
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

I think it looks good.

Thanks@corona10 !

@miss-islingtonmiss-islington merged commit87bd207 intopython:masterSep 5, 2019
@miss-islington
Copy link
Contributor

Thanks@corona10 for the PR 🌮🎉.. I'm working now to backport this PR to: 3.7, 3.8.
🐍🍒⛏🤖

miss-islington pushed a commit to miss-islington/cpython that referenced this pull requestSep 5, 2019
@bedevere-bot
Copy link

GH-15685 is a backport of this pull request to the3.8 branch.

@miss-islington
Copy link
Contributor

Sorry,@corona10, I could not cleanly backport this to3.7 due to a conflict.
Please backport usingcherry_picker on command line.
cherry_picker 87bd2071c756188b6cd577889fb1682831142ceb 3.7

@miss-islingtonmiss-islington self-assigned thisSep 5, 2019
@corona10corona10 deleted the bpo-22347 branchSeptember 5, 2019 00:38
@bedevere-bot
Copy link

GH-15687 is a backport of this pull request to the3.7 branch.

miss-islington added a commit that referenced this pull requestSep 5, 2019
maxking added a commit to maxking/cpython-1 that referenced this pull requestOct 12, 2019
miss-islington pushed a commit to miss-islington/cpython that referenced this pull requestOct 12, 2019
…er parsing of URLs (pythonGH-15522)" (pythonGH-16724)This reverts commit87bd207.https://bugs.python.org/issue38449(cherry picked from commit19a3d87)Co-authored-by: Abhilash Raj <maxking@users.noreply.github.com>
maxking added a commit that referenced this pull requestOct 12, 2019
maxking added a commit to maxking/cpython-1 that referenced this pull requestOct 12, 2019
…low oper parsing of URLs (pythonGH-15522)" (pythonGH-16724)This reverts commit87bd207.https://bugs.python.org/issue38449(cherry picked from commit19a3d87)Co-authored-by: Abhilash Raj <maxking@users.noreply.github.com>
jacobneiltaylor pushed a commit to jacobneiltaylor/cpython that referenced this pull requestDec 5, 2019
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Reviewers

@maxkingmaxkingmaxking approved these changes

@epicfaaceepicfaaceepicfaace approved these changes

Assignees

@miss-islingtonmiss-islington

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

6 participants
@corona10@bedevere-bot@miss-islington@maxking@epicfaace@the-knights-who-say-ni
[8]ページ先頭
©2009-2025 Movatter.jp