NotificationsYou must be signed in to change notification settings
Fork33.7k
Star70.4k

bpo-21161: pdb: default: handle list comprehensions#15194

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Jump to bottom

Closed

blueyed wants to merge1 commit intopython:mainfromblueyed:pdb-list-comprehensions

Closed

bpo-21161: pdb: default: handle list comprehensions#15194

blueyed wants to merge1 commit intopython:mainfromblueyed:pdb-list-comprehensions

Conversation

Copy link

Contributor

blueyed commentedAug 9, 2019•
edited
Loading

Fixeshttps://bugs.python.org/issue21161.

TODO:

test
news
attribute patch author (Xavier de Gaye (xdegaye),@xdegaye)

https://bugs.python.org/issue21161

the-knights-who-say-ni added the CLA signed label

Aug 9, 2019

bedevere-bot added the awaiting review label

Aug 9, 2019

Copy link

ContributorAuthor

blueyed commentedAug 9, 2019•
edited
Loading

test_gdb crashed on Azure (https://dev.azure.com/Python/cpython/_build/results?buildId=48361&view=logs&j=c83831cd-3752-5cc7-2f01-8276919eb334):

0:12:45 load avg: 0.01 [418/419] test_io passed (4 min 23 sec) -- running: test_gdb (10 min 1 sec)running: test_gdb (10 min 31 sec)running: test_gdb (11 min 1 sec)running: test_gdb (11 min 31 sec)running: test_gdb (15 min 31 sec)running: test_gdb (16 min 1 sec)running: test_gdb (16 min 31 sec)running: test_gdb (17 min 1 sec)running: test_gdb (17 min 31 sec)running: test_gdb (18 min 1 sec)running: test_gdb (18 min 31 sec)running: test_gdb (19 min 1 sec)running: test_gdb (19 min 31 sec)Timeout (0:20:00)!0:22:44 load avg: 0.00 [419/419/1] test_gdb crashed (Exit code 1)Thread 0x00000fa4 (most recent call first):File "D:\a\1\s\lib\subprocess.py", line 1353 in _readerthreadFile "D:\a\1\s\lib\threading.py", line 876 in runFile "D:\a\1\s\lib\threading.py", line 938 in _bootstrap_innerFile "D:\a\1\s\lib\threading.py", line 896 in _bootstrapThread 0x000003f4 (most recent call first):File "D:\a\1\s\lib\subprocess.py", line 1353 in _readerthreadFile "D:\a\1\s\lib\threading.py", line 876 in runFile "D:\a\1\s\lib\threading.py", line 938 in _bootstrap_innerFile "D:\a\1\s\lib\threading.py", line 896 in _bootstrapThread 0x00000a7c (most recent call first):File "D:\a\1\s\lib\threading.py", line 1033 in _wait_for_tstate_lockFile "D:\a\1\s\lib\threading.py", line 1017 in joinFile "D:\a\1\s\lib\subprocess.py", line 1382 in _communicateFile "D:\a\1\s\lib\subprocess.py", line 1015 in communicateFile "D:\a\1\s\lib\test\test_gdb.py", line 105 in run_gdbFile "D:\a\1\s\lib\test\test_gdb.py", line 122 in gdb_has_frame_selectFile "D:\a\1\s\lib\test\test_gdb.py", line 129 in <module>File "<frozen importlib._bootstrap>", line 219 in _call_with_frames_removedFile "<frozen importlib._bootstrap_external>", line 782 in exec_module== Tests result: FAILURE ==

(retrying)

bpo-21161: pdb: default: handle list comprehensions

ff84fb3

Fixeshttps://bugs.python.org/issue21161.

blueyed force-pushed thepdb-list-comprehensions branch from00fac9a toff84fb3Compare

August 12, 2019 01:16

Copy link

viniciusd commentedAug 21, 2019

Congrats for the work here :)
It looks to me it covers other kinds of comprehensions as well, right? Like set and dictionary comprehension. What do you think of also testing those?

Copy link

ContributorAuthor

blueyed commentedAug 21, 2019

What do you think of also testing those?

I do not think it is necessary really - the test proves that the namespace is handled properly/differently already.

epicfaace reviewed

Aug 24, 2019

View reviewed changes

Lib/test/test_pdb.py

		deftest_list_comprehensions(self):
		script="""
		def f():
		mylocal = "init_mylocal" # noqa: F841

Copy link

Contributor

epicfaaceAug 24, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

What does the comment mean?

Copy link

gogobdFeb 16, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Local variable name is assigned to but never used (F841)

Lib/test/test_pdb.py

		commands="""
		continue

		p "mylocal:" + mylocal

Copy link

Contributor

epicfaaceAug 24, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Do you need this line in the test?

ccordoba12 mentioned this pull request

Oct 3, 2020

Variables not defined error while in debug mode when running a list comprehensionspyder-ide/spyder#13909

Closed

10 tasks

impact27 mentioned this pull request

Oct 3, 2020

PR: Use frame locals when evaluating code in Pdbspyder-ide/spyder-kernels#252

Merged

sweeneyde mentioned this pull request

Sep 26, 2021

BPO "GH-5195" MouseOver ToolTip text References "GH-15194"python/psf-infra-meta#129

Closed

impact27 reviewed

Sep 29, 2021

View reviewed changes

Lib/pdb.py

		ifline[:1]=='!':line=line[1:]
		locals=self.curframe_locals
		globals=self.curframe.f_globals
		ns=self.curframe.f_globals.copy()

Copy link

Contributor

impact27Sep 29, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

What it the code that is being debugged changesglobals()? This would mean any changes to self.curframe.f_globals by the calling code is dropped, is it not?