Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

Add missing space to warning message#14915

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
rhettinger merged 1 commit intopython:masterfromThe-Compiler:patch-1
Aug 22, 2019
Merged

Add missing space to warning message#14915

rhettinger merged 1 commit intopython:masterfromThe-Compiler:patch-1
Aug 22, 2019

Conversation

@The-Compiler
Copy link
Contributor

This was introduced inGH-13409 when changing the message text.

cc@Carreau

This should probably go to the 3.8 branch as well?

This was introduced inGH-13409 when changing the message text.
@the-knights-who-say-ni

Hello, and thanks for your contribution!

I'm a bot set up to make sure that the project can legally accept your contribution by verifying you have signed thePSF contributor agreement (CLA).

Unfortunately we couldn't find an account corresponding to your GitHub username onbugs.python.org (b.p.o) to verify you have signed the CLA (this might be simply due to a missing "GitHub Name" entry in your b.p.o account settings). This is necessary for legal reasons before we can look at your contribution. Please followthe steps outlined in the CPython devguide to rectify this issue.

You cancheck yourself to see if the CLA has been received.

Thanks again for your contribution, we look forward to reviewing it!

@Carreau
Copy link
Contributor

Oops, thanks !

warnings.warn("Using or importing the ABCs from 'collections' instead "
"of from 'collections.abc' is deprecated since Python 3.3,"
"of from 'collections.abc' is deprecated since Python 3.3,"
"and in 3.9 it will stop working",
Copy link
Contributor

@aerosaerosJul 26, 2019
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

This might not be necessary, but it looks like it's also missing a period at the end.

Copy link
ContributorAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

FWIW looks like most warning messages (grep -R -F -A2 'warnings.warn(' Lib) don't have a trailing dot.

Copy link
Contributor

@aerosaerosJul 26, 2019
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Oh my mistake then, feel free to disregard that suggestion.

@aeros
Copy link
Contributor

@The-Compiler Thanks for the contribution! Yes, this should be backported to 3.8 as well since the space is also missing on that branch.

@The-Compiler
Copy link
ContributorAuthor

FWIW I signed the CLA right after opening this PR, but looks like it hasn't been received yet?

@aeros
Copy link
Contributor

@The-Compiler CLA approval usually takes around 24 hours. Sometimes though you have to manually refresh the status on GitHub, use the link from@the-knights-who-say-ni:check yourself.

@The-Compiler
Copy link
ContributorAuthor

I'm aware - it's been three days and the checker still says "The-Compiler has not signed CLA".

@aeros
Copy link
Contributor

aeros commentedJul 26, 2019
edited
Loading

@The-Compiler The only other option that I'm aware of is sending an email tocontributors@python.org

@The-Compiler
Copy link
ContributorAuthor

@aeros167 Thanks, that helped - turns out I somehow have two bugs.python.org accounts ("The-Compiler" from 2012, "The Compiler" from 2014) but never noticed, and they accidentally marked the wrong one.

Anything else I need to do at this point? I don't think this needs a news item or issue number FWIW.

aeros reacted with thumbs up emoji

@aeros
Copy link
Contributor

aeros commentedJul 29, 2019
edited
Loading

@The-Compiler At this point, it's just waiting for a core dev review, they can add a skip news and skip issue label for you.

@miss-islington
Copy link
Contributor

Thanks@The-Compiler for the PR, and@rhettinger for merging it 🌮🎉.. I'm working now to backport this PR to: 3.8.
🐍🍒⛏🤖

@bedevere-bot
Copy link

GH-15379 is a backport of this pull request to the3.8 branch.

miss-islington pushed a commit to miss-islington/cpython that referenced this pull requestAug 22, 2019
This typo was introduced inpythonGH-13409 when changing the message text.(cherry picked from commitc4106af)Co-authored-by: Florian Bruhin <me@the-compiler.org>
rhettinger pushed a commit that referenced this pull requestAug 22, 2019
This typo was introduced inGH-13409 when changing the message text.(cherry picked from commitc4106af)Co-authored-by: Florian Bruhin <me@the-compiler.org>
@The-CompilerThe-Compiler deleted the patch-1 branchAugust 22, 2019 06:50
lisroach pushed a commit to lisroach/cpython that referenced this pull requestSep 10, 2019
This typo was introduced inpythonGH-13409 when changing the message text.
DinoV pushed a commit to DinoV/cpython that referenced this pull requestJan 14, 2020
This typo was introduced inpythonGH-13409 when changing the message text.
websurfer5 pushed a commit to websurfer5/cpython that referenced this pull requestJul 20, 2020
This typo was introduced inpythonGH-13409 when changing the message text.
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

@rhettingerrhettingerrhettinger approved these changes

+2 more reviewers

@aerosaerosaeros approved these changes

@CarreauCarreauCarreau approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

docsDocumentation in the Doc dirskip issueskip news

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

7 participants

@The-Compiler@the-knights-who-say-ni@Carreau@aeros@miss-islington@bedevere-bot@rhettinger

[8]ページ先頭

©2009-2025 Movatter.jp