Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

bpo-1346874: Add 'Expect: 100-Continue' support to httplib#14880

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Open
tbartlett0 wants to merge2 commits intopython:main
base:main
Choose a base branch
Loading
fromtbartlett0:fix-issue-1346874

Conversation

tbartlett0
Copy link

@tbartlett0tbartlett0 commentedJul 21, 2019
edited by bedevere-bot
Loading

Previously,http.client would always send content body immediately and ignore any 100 responses. This change makesHTTPClient.request() wait for a Continue response if theExpect: 100-Continue header is set, and adds a parameter toHTTPClient.getresponse() that will cause it to return 100 responses instead of eating them.

https://bugs.python.org/issue1346874

twosigmajab, jab, webwurst, and piontec reacted with thumbs up emoji
Previously, http.client would always send content body immediately and ignore any 100 responses. This changemakes HTTPClient.request() wait for a `Continue` response if the `Expect: 100-Continue` header is set, andadds a parameter to HTTPClient.getresponse() that will cause it to return 100 responses instead of eating them.
@tbartlett0
Copy link
Author

This PR is intended to be backwards-compatible, but I have identified two potential edge cases:

  • clients that currently setExpect: 100-Continue with a broken server that ignores the header: This will introduce a delay ofexpect_timeout seconds to each request. However, this can be fixed by a) not sending the header or b) settingexpect_timeout to 0.
  • anyone who redefinesHTTPClient.response_class: this is likely to be a breaking change, as a new kwarg is used onHTTPResponse.begin(). (This seems like a fairly rare situation, as it's not exposed as an__init__ param, but chances are that someone, somewhere has done it...)

@csabellacsabella requested review fromorsenthil and removed request fororsenthil andvadmiumJune 12, 2020 22:32
@quadoss
Copy link

Is there an update on this one, its been in open state for couple of years and I too have been hitting this and wanting to see when this would be merged

michael-o, kratsg, and ppolewicz reacted with thumbs up emoji

@emnoor-reef
Copy link

Just bumping. Is this PR on consideration for getting merged? Or, are there any other plans for#42550 ? I am encountering this problem at work.

@python-cla-bot
Copy link

python-cla-botbot commentedApr 6, 2025
edited
Loading

All commit authors signed the Contributor License Agreement.

CLA signed

@IngridMorstrad
Copy link

IngridMorstrad commentedApr 8, 2025
edited
Loading

Hi,@tbartlett0
Is this PR still being worked on? Or can someone else (me) take it over?

@AA-Turner
Copy link
Member

Tim would need to (re-)sign the CLA.

@tbartlett0
Copy link
Author

Hi, I haven't touched this since it was submitted, since there seemed to be limited interest and I ended up working around it in other ways. If someone else wants to take it on I have no problem with that (either using my code or rewriting their own, there might be a better way to achieve it)

@tbartlett0
Copy link
Author

@IngridMorstrad
I (re-)signed the CLA, hopefully that clears any issues if you wish to take this on now.

@IngridMorstrad
Copy link

I don't have permissions here, so created a new PR:#133276

Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Reviewers

@orsenthilorsenthilAwaiting requested review from orsenthil

Assignees
No one assigned
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

8 participants
@tbartlett0@quadoss@emnoor-reef@IngridMorstrad@AA-Turner@the-knights-who-say-ni@ezio-melotti@bedevere-bot

[8]ページ先頭

©2009-2025 Movatter.jp