Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork34.3k
[3.14] gh-146041: Avoid lock in sys.intern() for already interned strings (gh-146072)#146390
Merged
colesbury merged 1 commit intopython:3.14fromMar 25, 2026
Merged
Conversation
…ed strings (pythongh-146072)Fix free-threading scaling bottleneck in sys.intern and `PyObject_SetAttr` byavoiding the interpreter-wide lock when the string is already interned andimmortalized.(cherry picked from commit6009309)Co-authored-by: Sam Gross <colesbury@gmail.com>
This was referencedMar 24, 2026
bedevere-bot commentedMar 24, 2026
🤖 New build scheduled with the buildbot fleet by@colesbury for commit7fa9a56 🤖 Results will be shown at: https://buildbot.python.org/all/#/grid?branch=refs%2Fpull%2F146390%2Fmerge If you want to schedule another build, you need to add the🔨 test-with-refleak-buildbots label again. |
f2b5131 intopython:3.14 94 of 96 checks passed
Uh oh!
There was an error while loading.Please reload this page.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading.Please reload this page.
Fix free-threading scaling bottleneck in sys.intern and
PyObject_SetAttrby avoiding the interpreter-wide lock when the string is already interned and immortalized.(cherry picked from commit6009309)
sys.intern()#146041