Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork34.3k
[3.10] gh-143930: Reject leading dashes in webbrowser URLs (GH-143931)#146359
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Merged
+20 −0
Merged
Changes fromall commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Uh oh!
There was an error while loading.Please reload this page.
Jump to
Jump to file
Failed to load files.
Loading
Uh oh!
There was an error while loading.Please reload this page.
Diff view
Diff view
There are no files selected for viewing
5 changes: 5 additions & 0 deletionsLib/test/test_webbrowser.py
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -57,6 +57,11 @@ def test_open(self): | ||
| options=[], | ||
| arguments=[URL]) | ||
| deftest_reject_dash_prefixes(self): | ||
| browser=self.browser_class(name=CMD_NAME) | ||
| withself.assertRaises(ValueError): | ||
| browser.open(f"--key=val{URL}") | ||
ambv marked this conversation as resolved. Show resolvedHide resolvedUh oh!There was an error while loading.Please reload this page. | ||
| classBackgroundBrowserCommandTest(CommandTestMixin,unittest.TestCase): | ||
14 changes: 14 additions & 0 deletionsLib/webbrowser.py
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -154,6 +154,12 @@ def open_new(self, url): | ||
| def open_new_tab(self, url): | ||
| return self.open(url, 2) | ||
| @staticmethod | ||
| def _check_url(url): | ||
| """Ensures that the URL is safe to pass to subprocesses as a parameter""" | ||
| if url and url.lstrip().startswith("-"): | ||
| raise ValueError(f"Invalid URL: {url}") | ||
ambv marked this conversation as resolved. Show resolvedHide resolvedUh oh!There was an error while loading.Please reload this page.
ambv marked this conversation as resolved. Show resolvedHide resolvedUh oh!There was an error while loading.Please reload this page. | ||
| class GenericBrowser(BaseBrowser): | ||
| """Class for all browsers started with a command | ||
| @@ -171,6 +177,7 @@ def __init__(self, name): | ||
| def open(self, url, new=0, autoraise=True): | ||
| sys.audit("webbrowser.open", url) | ||
| self._check_url(url) | ||
| cmdline = [self.name] + [arg.replace("%s", url) | ||
| for arg in self.args] | ||
| try: | ||
| @@ -191,6 +198,7 @@ def open(self, url, new=0, autoraise=True): | ||
| cmdline = [self.name] + [arg.replace("%s", url) | ||
| for arg in self.args] | ||
| sys.audit("webbrowser.open", url) | ||
| self._check_url(url) | ||
| try: | ||
| if sys.platform[:3] == 'win': | ||
| p = subprocess.Popen(cmdline) | ||
| @@ -256,6 +264,7 @@ def _invoke(self, args, remote, autoraise, url=None): | ||
| def open(self, url, new=0, autoraise=True): | ||
| sys.audit("webbrowser.open", url) | ||
| self._check_url(url) | ||
| if new == 0: | ||
| action = self.remote_action | ||
| elif new == 1: | ||
| @@ -357,6 +366,7 @@ class Konqueror(BaseBrowser): | ||
| def open(self, url, new=0, autoraise=True): | ||
| sys.audit("webbrowser.open", url) | ||
| self._check_url(url) | ||
| # XXX Currently I know no way to prevent KFM from opening a new win. | ||
| if new == 2: | ||
| action = "newTab" | ||
| @@ -441,6 +451,7 @@ def _remote(self, action): | ||
| def open(self, url, new=0, autoraise=True): | ||
| sys.audit("webbrowser.open", url) | ||
| self._check_url(url) | ||
| if new: | ||
| ok = self._remote("LOADNEW " + url) | ||
| else: | ||
| @@ -603,6 +614,7 @@ def register_standard_browsers(): | ||
| class WindowsDefault(BaseBrowser): | ||
| def open(self, url, new=0, autoraise=True): | ||
| sys.audit("webbrowser.open", url) | ||
| self._check_url(url) | ||
| try: | ||
| os.startfile(url) | ||
| except OSError: | ||
| @@ -633,6 +645,7 @@ def __init__(self, name): | ||
| def open(self, url, new=0, autoraise=True): | ||
| sys.audit("webbrowser.open", url) | ||
| self._check_url(url) | ||
| assert "'" not in url | ||
| # hack for local urls | ||
| if not ':' in url: | ||
| @@ -670,6 +683,7 @@ def __init__(self, name): | ||
| self._name = name | ||
| def open(self, url, new=0, autoraise=True): | ||
| self._check_url(url) | ||
| if self._name == 'default': | ||
| script = 'open location "%s"' % url.replace('"', '%22') # opens in default browser | ||
| else: | ||
1 change: 1 addition & 0 deletionsMisc/NEWS.d/next/Security/2026-01-16-12-04-49.gh-issue-143930.zYC5x3.rst
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1 @@ | ||
| Reject leading dashes in URLs passed to:func:`webbrowser.open` |
Oops, something went wrong.
Uh oh!
There was an error while loading.Please reload this page.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.