Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

gh-146197: Include a bit more information in sys._emscripten_info.runtime#146346

Merged
vstinner merged 1 commit intopython:mainfrom
hoodmane:emscripten-info-runtime
Mar 23, 2026
Merged

gh-146197: Include a bit more information in sys._emscripten_info.runtime#146346
vstinner merged 1 commit intopython:mainfrom
hoodmane:emscripten-info-runtime

Conversation

@hoodmane
Copy link
Contributor

@hoodmanehoodmane commentedMar 23, 2026
edited by bedevere-appbot
Loading

Before:sys._emscripten_info.runtime isNode.js/24, now it saysnode v24.14.0 (v8 13.6.233.17-node.41). I also added detection for node and bun.

@vstinner
Copy link
Member

pythoninfo of the Emscripten CI job says:

sys._emscripten_info: sys._emscripten_info(emscripten_version=(4, 0, 12), runtime='node v24.14.0 (v8 13.6.233.17-node.41)', pthreads=False, shared_memory=False)

needs backport to 3.14

I'm not sure that it's a good idea to changesys._emscripten_info.runtime in a Python 3.14.x bugfix release. Some projects may rely on the current string format.

Copy link
Member

@vstinnervstinner left a comment
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

LGTM. But it may safer to not backport the change to 3.14.

@hoodmane
Copy link
ContributorAuthor

Right, I suppose we don't need the backport for anything.

@hoodmanehoodmane removed the needs backport to 3.14bugs and security fixes labelMar 23, 2026
@vstinnervstinnerenabled auto-merge (squash)March 23, 2026 21:50
@vstinnervstinner merged commit7dc2f52 intopython:mainMar 23, 2026
63 checks passed
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

@vstinnervstinnervstinner approved these changes

@ericsnowcurrentlyericsnowcurrentlyAwaiting requested review from ericsnowcurrentlyericsnowcurrently is a code owner

Assignees

No one assigned

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@hoodmane@vstinner

[8]ページ先頭

©2009-2026 Movatter.jp