Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork34.3k
gh-143820: Fix assertion failure that occurred when insertingENTER_EXECUTOR afterBINARY_OP_INPLACE_ADD_UNICODE#146324
Open
cocolato wants to merge 2 commits intopython:mainfrom
Open
gh-143820: Fix assertion failure that occurred when insertingENTER_EXECUTOR afterBINARY_OP_INPLACE_ADD_UNICODE#146324cocolato wants to merge 2 commits intopython:mainfrom
ENTER_EXECUTOR afterBINARY_OP_INPLACE_ADD_UNICODE#146324cocolato wants to merge 2 commits intopython:mainfrom
Conversation
Fidget-Spinner approved these changesMar 23, 2026
Member
Fidget-Spinner left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Wow, this is incredibly smart! I like this solution! Thanks!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading.Please reload this page.
This PR calculate the target
STORE_FASTlocal variable index during the Specialization phase and store it in the instruction's own inline cache.So that:
ENTER_EXECUTOR.STORE_FASThas an index > 255 (which usesEXTENDED_ARGprefixes).next_instr->op.code == STORE_FASTfailed in_PyEval_EvalFrameDefault#143820