Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

gh-146261: Fix bug in_Py_uop_sym_set_func_version#146291

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
Changes fromall commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletionPython/optimizer_symbols.c
View file
Open in desktop
Original file line numberDiff line numberDiff line change
Expand Up@@ -522,7 +522,7 @@ _Py_uop_sym_set_func_version(JitOptContext *ctx, JitOptRef ref, uint32_t version
caseJIT_SYM_PREDICATE_TAG:
caseJIT_SYM_TRUTHINESS_TAG:
sym_set_bottom(ctx,sym);
returntrue;
returnfalse;

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Sorry, can you just reduce the PR to just this line? I'm really sorry for taking up your time on this Sacul.

After staring at this more, I realised the original function watcher idea works, but needs a lot more work. I think this might be too complicated for a contributor to take, so I'll take over. Thanks for opening the issue again and for spotting this mistake of mine!

Sacul0457 reacted with thumbs up emoji
Copy link
ContributorAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

No worries, glad to be able to help where I can :)

caseJIT_SYM_RECORDED_VALUE_TAG: {
PyObject*val=sym->recorded_value.value;
if (Py_TYPE(val)!=&PyFunction_Type||
Expand Down
Loading

[8]ページ先頭

©2009-2026 Movatter.jp