Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork34.3k
gh-146261: Fix bug in_Py_uop_sym_set_func_version#146291
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Changes fromall commits
File filter
Filter by extension
Conversations
Uh oh!
There was an error while loading.Please reload this page.
Jump to
Uh oh!
There was an error while loading.Please reload this page.
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -522,7 +522,7 @@ _Py_uop_sym_set_func_version(JitOptContext *ctx, JitOptRef ref, uint32_t version | ||
| caseJIT_SYM_PREDICATE_TAG: | ||
| caseJIT_SYM_TRUTHINESS_TAG: | ||
| sym_set_bottom(ctx,sym); | ||
| returnfalse; | ||
Member There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others.Learn more. Sorry, can you just reduce the PR to just this line? I'm really sorry for taking up your time on this Sacul. After staring at this more, I realised the original function watcher idea works, but needs a lot more work. I think this might be too complicated for a contributor to take, so I'll take over. Thanks for opening the issue again and for spotting this mistake of mine! ContributorAuthor There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others.Learn more. No worries, glad to be able to help where I can :) | ||
| caseJIT_SYM_RECORDED_VALUE_TAG: { | ||
| PyObject*val=sym->recorded_value.value; | ||
| if (Py_TYPE(val)!=&PyFunction_Type|| | ||
Uh oh!
There was an error while loading.Please reload this page.