Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork34.3k
gh-146261: Fix bug in_Py_uop_sym_set_func_version#146291
gh-146261: Fix bug in_Py_uop_sym_set_func_version#146291Fidget-Spinner merged 2 commits intopython:mainfrom
_Py_uop_sym_set_func_version#146291Conversation
| caseJIT_SYM_TRUTHINESS_TAG: | ||
| sym_set_bottom(ctx,sym); | ||
| returntrue; | ||
| returnfalse; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Sorry, can you just reduce the PR to just this line? I'm really sorry for taking up your time on this Sacul.
After staring at this more, I realised the original function watcher idea works, but needs a lot more work. I think this might be too complicated for a contributor to take, so I'll take over. Thanks for opening the issue again and for spotting this mistake of mine!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
No worries, glad to be able to help where I can :)
_CHECK_FUNCTION_VERSION in the JIT_Py_uop_sym_set_func_version
Fidget-Spinner left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Thanks!
1ceb1fb intopython:mainUh oh!
There was an error while loading.Please reload this page.
Uh oh!
There was an error while loading.Please reload this page.
Fixes a bug in
_Py_uop_sym_set_func_versionwhere it should returnfalseinstead oftruewhen we hit the bottom._CHECK_FUNCTION_VERSIONis wrong #146261