Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

gh-146245: Fix reference and buffer leaks via audit hook in socket module#146248

Merged
serhiy-storchaka merged 7 commits intopython:mainfrom
aisk:socket-audit-leak
Mar 22, 2026
Merged

gh-146245: Fix reference and buffer leaks via audit hook in socket module#146248
serhiy-storchaka merged 7 commits intopython:mainfrom
aisk:socket-audit-leak

Conversation

@aisk
Copy link
Member

@aiskaisk commentedMar 21, 2026•
edited by bedevere-appbot
Loading

@aiskaisk changed the titlegh-146245: Fix reference and buffer leaks audit hook in socket modulegh-146245: Fix reference and buffer leaks via audit hook in socket moduleMar 21, 2026
Copy link
Member

@serhiy-storchakaserhiy-storchaka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

The fix LGTM. I am not sure that it is worth to add such complicated and costly test. There is no precedence.

@aisk
Copy link
MemberAuthor

The fix LGTM. I am not sure that it is worth to add such complicated and costly test. There is no precedence.

The tests are reverted.

Copy link
Member

@serhiy-storchakaserhiy-storchaka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

LGTM. 👍

@serhiy-storchakaserhiy-storchaka added needs backport to 3.13bugs and security fixes needs backport to 3.14bugs and security fixes and removed awaiting merge labelsMar 22, 2026
@serhiy-storchakaserhiy-storchaka merged commitc30fae4 intopython:mainMar 22, 2026
94 of 102 checks passed
@miss-islington-app
Copy link

Thanks@aisk for the PR, and@serhiy-storchaka for merging it 🌮🎉.. I'm working now to backport this PR to: 3.13, 3.14.
🐍🍒⛏🤖

miss-islington pushed a commit to miss-islington/cpython that referenced this pull requestMar 22, 2026
…ket module (pythonGH-146248)(cherry picked from commit c30fae4bea9f9ba07833e97eb542754c26610765)Co-authored-by: AN Long <aisk@users.noreply.github.com>
miss-islington pushed a commit to miss-islington/cpython that referenced this pull requestMar 22, 2026
…ket module (pythonGH-146248)(cherry picked from commitc30fae4)Co-authored-by: AN Long <aisk@users.noreply.github.com>
@bedevere-app
Copy link

GH-146274 is a backport of this pull request to the3.14 branch.

@bedevere-appbedevere-appbot removed the needs backport to 3.14bugs and security fixes labelMar 22, 2026
@bedevere-app
Copy link

GH-146275 is a backport of this pull request to the3.13 branch.

@bedevere-appbedevere-appbot removed the needs backport to 3.13bugs and security fixes labelMar 22, 2026
serhiy-storchaka pushed a commit that referenced this pull requestMar 22, 2026
…cket module (GH-146248) (GH-146275)(cherry picked from commitc30fae4)Co-authored-by: AN Long <aisk@users.noreply.github.com>
serhiy-storchaka pushed a commit that referenced this pull requestMar 22, 2026
…cket module (GH-146248) (GH-146274)(cherry picked from commitc30fae4)Co-authored-by: AN Long <aisk@users.noreply.github.com>
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

@serhiy-storchakaserhiy-storchakaserhiy-storchaka approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@aisk@serhiy-storchaka
[8]ページ先頭
©2009-2026 Movatter.jp