gh-146245: Fix ref/buffer leaks in socketmodule.c on audit hook failure#146247

Closed

kimimgo wants to merge 1 commit intopython:mainfrom

kimimgo:fix/socket-audit-leak-146245

Closed

gh-146245: Fix ref/buffer leaks in socketmodule.c on audit hook failure#146247
kimimgo wants to merge 1 commit intopython:mainfrom
kimimgo:fix/socket-audit-leak-146245

Conversation

Copy link

kimimgo commentedMar 21, 2026•
edited by bedevere-appbot
Loading

Fixes#146245

Summary

Two leak bugs insocketmodule.c whenPySys_Audit raises:

1.`getaddrinfo` (line 6985)

return NULL skipped cleanup ofidna andpstr refs. Changed to
goto err which properly callsPy_XDECREF on both.

2.`sock_sendto` (line 4811)

return NULL skippedPyBuffer_Release(&pbuf). Added the release
before the return, matching the pattern used in adjacent error paths.

Issue:socketmodule.c: Reference and buffer leaks via audit hook failures #146245

pythongh-146245: Fix ref/buffer leaks in socketmodule.c on audit hook…

25217e7

… failureFix two leak bugs in socketmodule.c when PySys_Audit raises:1. getaddrinfo: 'return NULL' replaced with 'goto err' to ensure   idna and pstr refs are properly released via Py_XDECREF.2. sock_sendto: Added PyBuffer_Release(&pbuf) before 'return NULL'   to release the Py_buffer when audit hook raises.