Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork34.3k
[3.14] gh-145177: Add emscripten run --test, uses test args from config.toml (GH-146160)#146186
Merged
freakboy3742 merged 1 commit intopython:3.14fromMar 19, 2026
Merged
Conversation
…g.toml (pythonGH-146160)This allows us to change the test arguments from the python repo ratherthan having to change buildmaster-config.(cherry picked from commit6b5511d)Co-authored-by: Hood Chatham <roberthoodchatham@gmail.com>Co-authored-by: Russell Keith-Magee <russell@keith-magee.com>
freakboy3742 approved these changesMar 19, 2026
Contributor
freakboy3742 left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
👍
bc6edf8 intopython:3.14 55 checks passed
Uh oh!
There was an error while loading.Please reload this page.
Thanks@miss-islington for the PR, and@freakboy3742 for merging it 🌮🎉.. I'm working now to backport this PR to: 3.14. |
Sorry,@miss-islington and@freakboy3742, I could not cleanly backport this to |
Contributor
freakboy3742 commentedMar 19, 2026
/me facepalms backporting a 3.14 PR to 3.14... |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading.Please reload this page.
This allows us to change the test arguments from the python repo rather
than having to change buildmaster-config.
(cherry picked from commit6b5511d)
Co-authored-by: Hood Chathamroberthoodchatham@gmail.com
Co-authored-by: Russell Keith-Mageerussell@keith-magee.com