Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork34.3k
[3.14] gh-146056: Fix repr() for lists and tuples containing NULLs (GH-146129)#146155
Conversation
pythonGH-146129)(cherry picked from commit0f2246b)Co-authored-by: Serhiy Storchaka <storchaka@gmail.com>Co-authored-by: Victor Stinner <vstinner@python.org>
| Call :c:func:`PyObject_Repr` on *obj* and write the output into *writer*. | ||
| If *obj* is ``NULL``, write the string ``"<NULL>"`` into *writer*. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
I would prefer to not change PyUnicodeWriter_WriteRepr() in a Python 3.14.x bugfix release. Can you leave it unchanged? Instead, modify list_repr() and tuple_repr() to write<NULL> string explicitly.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
We need to modify not only list_repr() and tuple_repr(), but all code that usesPyUnicodeWriter_WriteRepr(). And what about the user code? We leave it with a mine which explodes in rare and most likely not tested case.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
In the Python code base, if I read the code correctly, onlytuple_repr() can callPyUnicodeWriter_WriteRepr() withNULL. For example,list_repr() cannot passNULL, becauseitem = Py_NewRef(v->ob_item[i]) crash if the item isNULL.
And what about the user code? We leave it with a mine which explodes in rare and most likely not tested case.
My concern is that if you develop on (the future) Python 3.14.4 withPyUnicodeWriter_WriteRepr() which acceptsNULL, you can get crashes if an user uses Python 3.14.0 which doesn't acceptNULL. I don't think that it's a good idea to change the API in a 3.14.x bugfix release.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Python 3.14.0 is broken. It crashes when you callrepr() for uninitialized list or tuple, and it can crash in other cases. Does it mean that we should not backport the bugfix? I think that it is the nature of bugfix releases that they make the code which failed in earlier releases to pass.
The documentation says thatPyUnicodeWriter_WriteRepr() callsPyObject_Repr() onobj and writes the output intowriter.PyObject_Repr() works with NULL.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
If you insist to change PyUnicodeWriter_WriteRepr() API, please add aversionchanged markup to document that the API changed.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
If we don't fix it in 3.14, we will need a versionchanged for 3.15. But we rarely add versionchanged for bugfixes, especially if the feature was added in the same version.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
I'm suggesting to add aversionchanged markup in the 3.14 change to say that the API changed in Python 3.14.x.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Done. Created also a PR for adding in in main.
vstinner left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
LGTM.
Ok, let's do that, accept NULL inPyUnicodeWriter_WriteRepr(). At least, the API change is now documented.
serhiy-storchaka commentedMar 20, 2026
Note that no |
7965133 intopython:3.14Uh oh!
There was an error while loading.Please reload this page.
Thanks@serhiy-storchaka for the PR 🌮🎉.. I'm working now to backport this PR to: 3.13. |
Sorry,@serhiy-storchaka, I could not cleanly backport this to |
…LLs (pythonGH-146129) (pythonGH-146155)(cherry picked from commit0f2246b)(cherry picked from commit7965133)Co-authored-by: Serhiy Storchaka <storchaka@gmail.com>Co-authored-by: Victor Stinner <vstinner@python.org>
…GH-146129) (pythonGH-146155)(cherry picked from commit0f2246b)(cherry picked from commit7965133)Co-authored-by: Serhiy Storchaka <storchaka@gmail.com>Co-authored-by: Victor Stinner <vstinner@python.org>
GH-146271 is a backport of this pull request to the3.13 branch. |
Uh oh!
There was an error while loading.Please reload this page.
(cherry picked from commit0f2246b)
📚 Documentation preview 📚:https://cpython-previews--146155.org.readthedocs.build/