gh-146091: Fix NULL check in termios.tcsetwinsize#146147

Merged

kumaraditya303 merged 1 commit intopython:mainfrom

okiemute04:fix-termios-tcsetwinsize

Mar 19, 2026

Merged

gh-146091: Fix NULL check in termios.tcsetwinsize#146147
kumaraditya303 merged 1 commit intopython:mainfrom
okiemute04:fix-termios-tcsetwinsize

Conversation

Copy link

Contributor

okiemute04 commentedMar 18, 2026•
edited by bedevere-appbot
Loading

Fixes#146091

Add proper NULL checks for PySequence_GetItem results before passing
to PyLong_AsLong, this prevents SystemError when a BadSequence raises
TypeError ingetitem, the issue was that PySequence_GetItem can return NULL, which when passed to PyLong_AsLong would cause an internal error instead of propagating
the original exception.

Issue:SystemError fromtermios.tcsetwinsizepassingNULL toPyLong_AsLong #146091

Copy link

bedevere-appbot commentedMar 18, 2026

Most changes to Pythonrequire a NEWS entry. Add one using theblurb_it web app or theblurb command-line tool.

If this change has little impact on Python users, wait for a maintainer to apply theskip news label instead.

Copy link

python-cla-botbot commentedMar 18, 2026•
edited
Loading

All commit authors signed the Contributor License Agreement.

bedevere-appbot mentioned this pull request

Mar 18, 2026

SystemError fromtermios.tcsetwinsizepassingNULL toPyLong_AsLong#146091

Closed

bedevere-appbot added the awaiting review label

Mar 18, 2026

okiemute04 force-pushed thefix-termios-tcsetwinsize branch fromae90cb1 to5e8ef92Compare

March 18, 2026 23:58

pythongh-146091: Fix NULL check in termios.tcsetwinsize

113df89

Add proper NULL checks for PySequence_GetItem results before passingto PyLong_AsLong. This prevents SystemError when a BadSequence raisesTypeError in __getitem__.

okiemute04 force-pushed thefix-termios-tcsetwinsize branch from5e8ef92 to113df89Compare

March 19, 2026 00:11