Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork34.3k
GH-145667: MergeGET_ITER andGET_YIELD_FROM_ITER#146120
Merged
markshannon merged 4 commits intopython:mainfromMar 21, 2026
Merged
GH-145667: MergeGET_ITER andGET_YIELD_FROM_ITER#146120markshannon merged 4 commits intopython:mainfrom
GET_ITER andGET_YIELD_FROM_ITER#146120markshannon merged 4 commits intopython:mainfrom
Conversation
diegorusso approved these changesMar 20, 2026
Contributor
diegorusso left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Just a nit
Uh oh!
There was an error while loading.Please reload this page.
Member
Fidget-Spinner commentedMar 20, 2026
Just to be sure, please run the buildbots |
bedevere-bot commentedMar 20, 2026
🤖 New build scheduled with the buildbot fleet by@markshannon for commite3ea233 🤖 Results will be shown at: https://buildbot.python.org/all/#/grid?branch=refs%2Fpull%2F146120%2Fmerge If you want to schedule another build, you need to add the🔨 test-with-buildbots label again. |
bedevere-bot commentedMar 20, 2026
🤖 New build scheduled with the buildbot fleet by@markshannon for commit1b8f043 🤖 Results will be shown at: https://buildbot.python.org/all/#/grid?branch=refs%2Fpull%2F146120%2Fmerge If you want to schedule another build, you need to add the🔨 test-with-buildbots label again. |
MemberAuthor
markshannon commentedMar 21, 2026
Of the 12 failing buildbots, 7 were pre-existing failures and 5 are "new" refleaks. However, since this PR is platform independent, there should be leaks everywhere or nowhere. |
879c85f intopython:main 147 of 160 checks passed
Uh oh!
There was an error while loading.Please reload this page.
bedevere-bot commentedMar 21, 2026
|
CuriousLearner added a commit to CuriousLearner/cpython that referenced this pull requestMar 22, 2026
* upstream/main: (1475 commits) Docs: replace all `datetime` imports with `import datetime as dt` (python#145640)pythongh-146153: Use `frozendict` in pure python fallback for `curses.has_key` (python#146154)pythongh-138234: clarify returncode behavior for subprocesses created with `shell=True` (python#138536)pythongh-140947: fix contextvars handling for server tasks in asyncio (python#141158)pythonGH-100108: Add async generators best practices section (python#141885)pythonGH-145667: Merge `GET_ITER` and `GET_YIELD_FROM_ITER` (pythonGH-146120)pythongh-146228: Better fork support in cached FastPath (python#146231)pythongh-146227: Fix wrong type in _Py_atomic_load_uint16 in pyatomic_std.h (pythongh-146229)pythongh-145980: Fix copy/paste mistake in binascii.c (python#146230)pythongh-146092: Raise MemoryError on allocation failure in _zoneinfo (python#146165)pythongh-91279: Note `SOURCE_DATE_EPOCH` support in `ZipFile.writestr()` doc (python#139396)pythongh-146196: Fix Undefined Behavior in _PyUnicodeWriter_WriteASCIIString() (python#146201)pythongh-143930: Reject leading dashes in webbrowser URLspythongh-145916: Soft-deprecate ctypes.util.find_library (pythonGH-145919)pythongh-146205: Check the errno with != 0 in close impls in select module (python#146206)pythongh-146171: Fix nested AttributeError suggestions (python#146188)pythongh-146099: Optimize _GUARD_CODE_VERSION+IP via function version symbols (pythonGH-146101)pythongh-145980: Add support for alternative alphabets in the binascii module (pythonGH-145981)pythongh-145754: Update signature retrieval in unittest.mock to use forwardref annotation format (python#145756)pythongh-145177: Add emscripten run --test, uses test args from config.toml (python#146160) ...
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Labels
None yet
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading.Please reload this page.
Also modifies
SENDto make it a bit more like FOR_ITER as both are now fed byGET_ITER.Apart from saving an opcode, this will enable broadly similar optimizations to be applied to
SENDas are already applied toFOR_ITER. Which will be able to:yield from seqwhereseqis a common iterable, likelist.SENDas it will be mostly specialized.For now, this is broadly performance neutral, between +0% and -1%, mostly about 0%.
GET_ITERandGET_YIELD_FROM_ITERinstructions #145667