python/cpythonPublic

NotificationsYou must be signed in to change notification settings
Fork34.3k
Star72.1k

gh-145866: Convert`CALL_INTRINSIC_1` to leave its inputs on the stack to be cleaned up by`_POP_TOP`.#145964

Merged

markshannon merged 4 commits intopython:mainfrom

Sacul0457:Optimize_CALL_INTRINSIC_1

Mar 16, 2026

Merged

gh-145866: Convert`CALL_INTRINSIC_1` to leave its inputs on the stack to be cleaned up by`_POP_TOP`.#145964
markshannon merged 4 commits intopython:mainfrom
Sacul0457:Optimize_CALL_INTRINSIC_1

Conversation

Copy link

Contributor

Sacul0457 commentedMar 15, 2026•
edited by bedevere-appbot
Loading

Issue:Convert more uops to leave their inputs on the stack to be cleaned up by_POP_TOP #145866

eliminate redundant refcounting for CALL_INTRINSIC_1

95b2357

Sacul0457 requested review fromFidget-Spinner,markshannon,savannahostrowski andtomasr8 ascode owners

March 15, 2026 04:27

bedevere-appbot added the awaiting review label

Mar 15, 2026

bedevere-appbot mentioned this pull request

Mar 15, 2026

Convert more uops to leave their inputs on the stack to be cleaned up by_POP_TOP#145866

Open

📜🤖 Added by blurb_it.

ef2b0b7

Fidget-Spinner approved these changes

Mar 15, 2026

View reviewed changes

Copy link

Member

Fidget-Spinner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Thanks

bedevere-appbot added awaiting merge and removed awaiting review labels

Mar 15, 2026

corona10 added the skip news label

Mar 15, 2026

corona10 reviewed

Mar 15, 2026

View reviewed changes

Misc/NEWS.d/next/Core_and_Builtins/2026-03-15-04-27-17.gh-issue-145866.1oBN2p.rst Outdated

		@@ -0,0 +1 @@
		Convert ``CALL_INTRINSIC_1`` to leave its inputs on the stack to be cleaned up by ``_POP_TOP``.

Copy link

Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

nit: NEWS.d is not needed until this is affected to end-users.

Copy link

ContributorAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Deleted, thx

Delete Misc/NEWS.d/next/Core_and_Builtins/2026-03-15-04-27-17.gh-issu…

bd9d77b

…e-145866.1oBN2p.rst

Fidget-Spinner requested changes

Mar 15, 2026

View reviewed changes

Python/bytecodes.c Outdated

Comment on lines +1252 to +1256

		v = value;
		DEAD(value);
		if (res_o == NULL) {
		ERROR_NO_POP();
		}

Copy link

Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Sorry I made a mistake, I thinkv should only transfer ownership after the error branch.

bedevere-appbot added awaiting changes and removed awaiting merge labels

Mar 15, 2026

Copy link

bedevere-appbot commentedMar 15, 2026

A Python core developer has requested some changes be made to your pull request before we can consider merging it. If you could please address their requests along with any other requests in other reviews from core developers that would be appreciated.

Once you have made the requested changes, please leave a comment on this pull request containing the phraseI have made the requested changes; please review again. I will then notify any core developers who have left a review that you're ready for them to take another look at this pull request.