Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

GH-145762: Fix test_ci_fuzz_stdlib when running the tests after building from the source archive#145778

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Open
chris-eibl wants to merge1 commit intopython:main
base:main
Choose a base branch
Loading
fromchris-eibl:fix_test_ci_fuzz_stdlib_part2
Open
Changes fromall commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletionLib/test/test_tools/test_compute_changes.py
View file
Open in desktop
Original file line numberDiff line numberDiff line change
Expand Up@@ -55,7 +55,7 @@ def test_ci_fuzz_stdlib(self):
elifp.is_file():
f=p
else:
self.fail(f"LIBRARY_FUZZER_PATHS contains an invalid entry:{p!r}")
continue
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

@StanFromIreland do we still want to log this, though? Or perhaps have a mechanism for skipping checks / checking against different sets of files in certain envs?

Copy link
Member

@StanFromIrelandStanFromIrelandMar 10, 2026
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Or perhaps have a mechanism for skipping checks / checking against different sets of files in certain envs?

As I noted in the issue, this will greatly complicate the test (and increase the maintenance burden, who knows what envs people use), for something that is not particularly important. As such, I think skipping is fine, logging them too, however, sounds good.

chris-eibl reacted with thumbs up emoji
Copy link
MemberAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

"Simple prints" will get lost in the noise of the output, and be false-positives in the OPs case.

I don't think

print(f"Warning: LIBRARY_FUZZER_PATHS might contain an invalid entry:{p!r}")

will do any good.
So I think this is fine to go. It was the previous behaviour, anyway. I just thought it is a low hanging fruit to crop when the else was removed in#145232 and we had spurious failures ...

result=process_changed_files({f})
self.assertTrue(result.run_ci_fuzz_stdlib)
self.assertTrue(is_fuzzable_library_file(f))
Expand Down
Loading

[8]ページ先頭

©2009-2026 Movatter.jp