Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

GH-145762: Fix test_ci_fuzz_stdlib when running the tests after building from the source archive#145778

Open
chris-eibl wants to merge 1 commit intopython:mainfrom
chris-eibl:fix_test_ci_fuzz_stdlib_part2
Open

GH-145762: Fix test_ci_fuzz_stdlib when running the tests after building from the source archive#145778
chris-eibl wants to merge 1 commit intopython:mainfrom
chris-eibl:fix_test_ci_fuzz_stdlib_part2

Conversation

@chris-eibl
Copy link
Member

@chris-eiblchris-eibl commentedMar 10, 2026
edited by bedevere-appbot
Loading

when running the tests after building from the source archive
f=p
else:
self.fail(f"LIBRARY_FUZZER_PATHS contains an invalid entry:{p!r}")
continue
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

@StanFromIreland do we still want to log this, though? Or perhaps have a mechanism for skipping checks / checking against different sets of files in certain envs?

Copy link
Member

@StanFromIrelandStanFromIrelandMar 10, 2026
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Or perhaps have a mechanism for skipping checks / checking against different sets of files in certain envs?

As I noted in the issue, this will greatly complicate the test (and increase the maintenance burden, who knows what envs people use), for something that is not particularly important. As such, I think skipping is fine, logging them too, however, sounds good.

chris-eibl reacted with thumbs up emoji
Copy link
MemberAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

"Simple prints" will get lost in the noise of the output, and be false-positives in the OPs case.

I don't think

print(f"Warning: LIBRARY_FUZZER_PATHS might contain an invalid entry:{p!r}")

will do any good.
So I think this is fine to go. It was the previous behaviour, anyway. I just thought it is a low hanging fruit to crop when the else was removed in#145232 and we had spurious failures ...

Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

@webknjazwebknjazwebknjaz left review comments

@AA-TurnerAA-TurnerAwaiting requested review from AA-TurnerAA-Turner is a code owner

@hugovkhugovkAwaiting requested review from hugovkhugovk is a code owner

@StanFromIrelandStanFromIrelandAwaiting requested review from StanFromIreland

Assignees

No one assigned

Labels

awaiting reviewskip newstestsTests in the Lib/test dir

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@chris-eibl@webknjaz@StanFromIreland

[8]ページ先頭

©2009-2026 Movatter.jp