python/cpythonPublic

NotificationsYou must be signed in to change notification settings
Fork34.2k
Star72k

gh-128341: Simplify the definition of _Py_INTERNAL_ABI_SLOT and use it in stdlib modules#145770

Open

befeleme wants to merge 2 commits intopython:mainfrom

befeleme:internal-abi-slot

Open

gh-128341: Simplify the definition of _Py_INTERNAL_ABI_SLOT and use it in stdlib modules#145770
befeleme wants to merge 2 commits intopython:mainfrom
befeleme:internal-abi-slot

Conversation

Copy link

Contributor

befeleme commentedMar 10, 2026•
edited by bedevere-appbot
Loading

Please consider discussing this in the issue linked, rather than it the PR, since this would ping a huge list of reviewers.

Issue:Segfault when updating from 3.13.0 to 3.13.1 while Python is running #128341

befeleme added2 commits

March 10, 2026 17:28

Define _Py_ABI_SLOT using _PyABIInfo_DEFAULT

1b23d9f

_PyABIInfo_DEFAULT is available in Include/modsupport.h, there's not needto duplicate the definition here.Rename from _Py_INTERNAL_ABI_SLOT, as it's no longer internal.

Use the ABI slot in stdlib modules

4a2fd0e

This enables running a check of ABI version compatibility._tkinter, _tracemalloc and readline don't use the slots, hence they needexplicit handling.

befeleme requested review from1st1,AA-Turner,AlexWaygood,FFY00,JelleZijlstra,StanFromIreland,abalkin,ammaraskar,asvetlov,berkerpeksag,brettcannon,corona10,emmatyping,ericsnowcurrently,erlend-aasland,gpshead,kumaraditya303,lysnikolaou,ncoghlan,pablogsal,pganssle,picnixz,rhettinger,serhiy-storchaka,warsaw andwillingc ascode owners

March 10, 2026 16:47

bedevere-appbot mentioned this pull request

Mar 10, 2026

Segfault when updating from 3.13.0 to 3.13.1 while Python is running#128341

Open

bedevere-appbot added the awaiting review label

Mar 10, 2026

encukou added the skip news label

Mar 10, 2026

AlexWaygood removed their request for review

March 10, 2026 16:49

encukou approved these changes

Mar 10, 2026

View reviewed changes

bedevere-appbot added awaiting merge and removed awaiting review labels

Mar 10, 2026

kumaraditya303 requested changes

Mar 10, 2026

View reviewed changes

Modules/_asynciomodule.c

		}

		static struct PyModuleDef_Slot module_slots[] = {
		_Py_ABI_SLOT,

Copy link

Contributor

kumaraditya303Mar 10, 2026•
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

_asyncio is a builtin module as it is statically linked, this check is not needed as it is not a shared library module.

bedevere-appbot added awaiting changes and removed awaiting merge labels

Mar 10, 2026

Copy link

bedevere-appbot commentedMar 10, 2026

A Python core developer has requested some changes be made to your pull request before we can consider merging it. If you could please address their requests along with any other requests in other reviews from core developers that would be appreciated.

Once you have made the requested changes, please leave a comment on this pull request containing the phraseI have made the requested changes; please review again. I will then notify any core developers who have left a review that you're ready for them to take another look at this pull request.