Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork34.2k
gh-145492: Fix test_repr_recursive_factory reproducer#145761
Open
mvanhorn wants to merge 1 commit intopython:mainfrom
Open
gh-145492: Fix test_repr_recursive_factory reproducer#145761mvanhorn wants to merge 1 commit intopython:mainfrom
mvanhorn wants to merge 1 commit intopython:mainfrom
Conversation
The test's ProblematicFactory.__repr__ called repr(dd) but discarded theresult, returning a fixed string instead. This didn't properly exercisethe infinite recursion path from the original issue where repr(dd) isembedded in the return value.Use `return f"ProblematicFactory for {repr(dd)}"` to match the originalreproducer frompythongh-145492.Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com> This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The test's
ProblematicFactory.__repr__calledrepr(dd)but discarded the result, returning a fixed string instead. This didn't properly exercise the infinite recursion path from the original issue whererepr(dd)is embedded in the return value.Changed to
return f"ProblematicFactory for {repr(dd)}"to match the original reproducer fromgh-145492.Happy to close this if@KowalskiThomas wants to submit the fix-up instead.