Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork34.2k
gh-145754: Update signature retrieval in unittest.mock to use forwardref annotation format#145756
Open
mschoettle wants to merge 5 commits intopython:mainfrom
Open
gh-145754: Update signature retrieval in unittest.mock to use forwardref annotation format#145756mschoettle wants to merge 5 commits intopython:mainfrom
mschoettle wants to merge 5 commits intopython:mainfrom
Conversation
Most changes to Pythonrequire a NEWS entry. Add one using theblurb_it web app or theblurb command-line tool. If this change has little impact on Python users, wait for a maintainer to apply the |
Member
JelleZijlstra commentedMar 10, 2026
This change looks right to me, please add a unit test and we'll hopefully get it merged! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading.Please reload this page.
Uses annotation format
FORWARDREFinstead of the defaultVALUEwhen callinginspect.signature.STRINGalso seems to work but affects existing tests that check the signature.unittest.mockis less robust with PEP 649 #145754Closes#145754