Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork34.2k
_struct.c: Fix UB from integer overflow inprepare_s#145750
Merged
serhiy-storchaka merged 2 commits intopython:mainfromMar 10, 2026
Merged
_struct.c: Fix UB from integer overflow inprepare_s#145750serhiy-storchaka merged 2 commits intopython:mainfrom
_struct.c: Fix UB from integer overflow inprepare_s#145750serhiy-storchaka merged 2 commits intopython:mainfrom
Conversation
serhiy-storchaka approved these changesMar 10, 2026
Member
serhiy-storchaka left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
LGTM. 👍
4d0dce0 intopython:main 101 of 104 checks passed
Uh oh!
There was an error while loading.Please reload this page.
Thanks@StanFromIreland for the PR, and@serhiy-storchaka for merging it 🌮🎉.. I'm working now to backport this PR to: 3.13, 3.14. |
miss-islington pushed a commit to miss-islington/cpython that referenced this pull requestMar 10, 2026
…thonGH-145750)(cherry picked from commit4d0dce0)Co-authored-by: Stan Ulbrych <89152624+StanFromIreland@users.noreply.github.com>
Sorry,@StanFromIreland and@serhiy-storchaka, I could not cleanly backport this to |
GH-145772 is a backport of this pull request to the3.14 branch. |
StanFromIreland added a commit to StanFromIreland/cpython that referenced this pull requestMar 10, 2026
…ule (pythonGH-145750)(cherry picked from commit4d0dce0)Co-authored-by: Stan Ulbrych <89152624+StanFromIreland@users.noreply.github.com>
GH-145777 is a backport of this pull request to the3.13 branch. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Like#145158. I checked the remaining paths in
prepare_sand there are no remaining possible cases for UB.