Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

bpo-37493: use _PyObject_CallNoArg in more places#14575

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
methane merged 1 commit intopython:masterfromjdemeyer:call_no_args
Jul 4, 2019

Conversation

jdemeyer
Copy link
Contributor

@jdemeyerjdemeyer commentedJul 3, 2019
edited by bedevere-bot
Loading

skrah
skrah previously requested changesJul 3, 2019
Copy link
Contributor

@skrahskrah left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

I'm a bit surprised --- we discussed on bpo to use fewer places, but you add more.

So please take out the decimal changes. I'll add new functions as I see fit.

@bedevere-bot
Copy link

A Python core developer has requested some changes be made to your pull request before we can consider merging it. If you could please address their requests along with any other requests in other reviews from core developers that would be appreciated.

Once you have made the requested changes, please leave a comment on this pull request containing the phraseI have made the requested changes; please review again. I will then notify any core developers who have left a review that you're ready for them to take another look at this pull request.

And if you don't make the requested changes,you will be poked with soft cushions!

@jdemeyer
Copy link
ContributorAuthor

jdemeyer commentedJul 3, 2019
edited by bedevere-bot
Loading

we discussed on bpo to use fewer places, but you add more.

I'm not sure what you mean. The only thing that we discussed (onbpo-37483 which relates to a different PR) is that maybe we should not use private functions in_decimal.c. However, in this case I'm using a documented public function, belonging to the limited APIPyObject_CallNoArgs.

So please let me know whether the changes to_decimal.c should be reverted anyway.

@skrah
Copy link
Contributor

The PR title mentions_PyObject_CallNoArg(). I see now that there are other functions in the_decimal.c diff, but again not in speed sensitive locations.

So perhaps there are too many new functions. I'll decide later if to use any of these, so yes, please take them out.

@jdemeyer
Copy link
ContributorAuthor

not in speed sensitive locations.

Even if it's not speed sensitive, I see no reason to preferPyObject_CallObject(func, NULL) overPyObject_CallNoArgs(func).

@jdemeyer
Copy link
ContributorAuthor

I have made the requested changes; please review again

@bedevere-bot
Copy link

Thanks for making the requested changes!

@skrah: please review the changes made to this pull request.

@skrahskrah self-requested a reviewJuly 4, 2019 09:52
Copy link
Contributor

@skrahskrah left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Thanks for the changes.

@skrahskrah dismissed theirstale reviewJuly 4, 2019 09:56

Changes have been made.

@methanemethane merged commit7f41c8e intopython:masterJul 4, 2019
@jdemeyerjdemeyer deleted the call_no_args branchJuly 4, 2019 10:46
lisroach pushed a commit to lisroach/cpython that referenced this pull requestSep 10, 2019
DinoV pushed a commit to DinoV/cpython that referenced this pull requestJan 14, 2020
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Reviewers

@skrahskrahskrah left review comments

@rhettingerrhettingerAwaiting requested review from rhettinger

Assignees
No one assigned
Labels
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

5 participants
@jdemeyer@bedevere-bot@skrah@methane@the-knights-who-say-ni

[8]ページ先頭

©2009-2025 Movatter.jp