Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork34.2k
[3.13] gh-145548: Don't use VMADDR_CID_LOCAL fromsocket#145735
[3.13] gh-145548: Don't use VMADDR_CID_LOCAL fromsocket#145735encukou merged 1 commit intopython:3.13from
socket#145735Conversation
VMADDR_CID_LOCAL was added to `socekt` in 3.14. The test needs alocal constant in setUp(), as in clientSetUp().
encukou commentedMar 10, 2026
!buildbot Fedora.Stable$ |
bedevere-bot commentedMar 10, 2026
The regex 'Fedora.Stable$' did not match any buildbot builder. Is the requested builder in the list of stable builders? |
encukou commentedMar 10, 2026
!buildbot Fedora.Stable |
bedevere-bot commentedMar 10, 2026
🤖 New build scheduled with the buildbot fleet by@encukou for commit9a6de87 🤖 Results will be shown at: https://buildbot.python.org/all/#/grid?branch=refs%2Fpull%2F145735%2Fmerge The command will test the builders whose names match following regular expression: The builders matched are:
|
vstinner left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
LGTM.
I tested manually on Fedora Stable x86-64: the change works as expected. The test is skipped:
testStream (test.test_socket.ThreadedVSOCKSocketStreamTest.testStream) ... skipped "bind() failed with OSError(99, 'Cannot assign requested address')"26326a0 intopython:3.13Uh oh!
There was an error while loading.Please reload this page.
Uh oh!
There was an error while loading.Please reload this page.
VMADDR_CID_LOCAL was added to
socketin 3.14.For 3.13, the test needs a local constant in setUp(), as in clientSetUp().